Skip to content

Commit 30ecabb

Browse files
Releasing v4.28.4
1 parent 76631f8 commit 30ecabb

File tree

15 files changed

+34
-19
lines changed

15 files changed

+34
-19
lines changed

.pubnub.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
---
22
changelog:
3+
-
4+
changes:
5+
-
6+
text: "Fixes issue of high cpu usage when heartbeat interval is not set."
7+
type: bug
8+
date: 2020-07-15
9+
version: v4.28.4
310
-
411
changes:
512
-
@@ -861,4 +868,4 @@ supported-platforms:
861868
- "Ubuntu 14.04 and up"
862869
- "Windows 7 and up"
863870
version: "Pubnub Javascript for Node"
864-
version: "4.28.3"
871+
version: "4.28.4"

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## [v4.28.4](https://github.com/pubnub/javascript/releases/tag/v4.28.4)
2+
July-15-2020
3+
4+
[Full Changelog](https://github.com/pubnub/javascript/compare/v4.28.3...v4.28.4)
5+
6+
- 🐛 Fixes issue of high cpu usage when heartbeat interval is not set.
7+
18
## [v4.28.3](https://github.com/pubnub/javascript/releases/tag/v4.28.3)
29
July-15-2020
310

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ please use the [master_3x](https://github.com/pubnub/javascript/tree/master_3x)
2222

2323

2424

25-
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.3.min.js
26-
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.3.js
25+
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.4.min.js
26+
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.4.js

dist/titanium/pubnub.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! 4.28.3 / Consumer */
1+
/*! 4.28.4 / Consumer */
22
exports["PubNub"] =
33
/******/ (function(modules) { // webpackBootstrap
44
/******/ // The module cache
@@ -506,7 +506,7 @@ var _default = function () {
506506
}, {
507507
key: "getVersion",
508508
value: function getVersion() {
509-
return '4.28.3';
509+
return '4.28.4';
510510
}
511511
}, {
512512
key: "_addPnsdkSuffix",
@@ -3591,7 +3591,7 @@ var _default = function () {
35913591
value: function _registerHeartbeatTimer() {
35923592
this._stopHeartbeatTimer();
35933593

3594-
if (this._config.getHeartbeatInterval() === 0) {
3594+
if (this._config.getHeartbeatInterval() === 0 || this._config.getHeartbeatInterval() === undefined) {
35953595
return;
35963596
}
35973597

dist/titanium/pubnub.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/web/pubnub.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! 4.28.3 / Consumer */
1+
/*! 4.28.4 / Consumer */
22
(function webpackUniversalModuleDefinition(root, factory) {
33
if(typeof exports === 'object' && typeof module === 'object')
44
module.exports = factory();
@@ -516,7 +516,7 @@ var _default = function () {
516516
}, {
517517
key: "getVersion",
518518
value: function getVersion() {
519-
return '4.28.3';
519+
return '4.28.4';
520520
}
521521
}, {
522522
key: "_addPnsdkSuffix",
@@ -3499,7 +3499,7 @@ var _default = function () {
34993499
value: function _registerHeartbeatTimer() {
35003500
this._stopHeartbeatTimer();
35013501

3502-
if (this._config.getHeartbeatInterval() === 0) {
3502+
if (this._config.getHeartbeatInterval() === 0 || this._config.getHeartbeatInterval() === undefined) {
35033503
return;
35043504
}
35053505

dist/web/pubnub.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/core/components/config.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/core/components/config.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/core/components/subscription_manager.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)