Skip to content

Commit 1254fa0

Browse files
committed
uuid changes
1 parent ba096d0 commit 1254fa0

File tree

9 files changed

+19
-5
lines changed

9 files changed

+19
-5
lines changed

PubNubUnity/Assets/PubNub/Editor/EditorCommon.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public class EditorCommon
5050
public bool DeliveryStatus { get; set; }
5151

5252
public static PubNub InitPN(PNConfiguration pnConfig){
53+
pnConfig.UUID = PubNub.GenerateUUID();
5354
return new PubNub(pnConfig);
5455
}
5556

@@ -62,6 +63,7 @@ public static PNConfiguration CreatePNConfig(){
6263
pnConfiguration.LogVerbosity = PNLogVerbosity.BODY;
6364
pnConfiguration.PresenceTimeout = 60;
6465
pnConfiguration.PresenceInterval= 30;
66+
pnConfiguration.UUID = PubNub.GenerateUUID();
6567
return pnConfiguration;
6668
}
6769

PubNubUnity/Assets/PubNub/Editor/PNConfigurationTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ public class PNConfigurationTests
1313
public void TestPNinGenerateGuid ()
1414
{
1515
PNConfiguration pnConfig = new PNConfiguration();
16+
pnConfig.UUID = PubNub.GenerateUUID();
1617
Assert.IsTrue(pnConfig.UUID.Contains("pn-"));
1718
}
1819
#endif

PubNubUnity/Assets/PubNub/Examples/Example.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,7 @@ void Init(){
487487
pnConfiguration.HeartbeatNotificationOption = PNHeartbeatNotificationOption.All;
488488

489489
//TODO: remove
490-
pnConfiguration.UUID = "PubNubUnityExample";
490+
pnConfiguration.UUID = PubNub.GenerateUUID();
491491
Debug.Log ("PNConfiguration");
492492
pubnub = new PubNub (pnConfiguration);
493493

PubNubUnity/Assets/PubNub/Helpers/CommonText.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@ internal static class CommonText
66
{
77
internal static readonly string DuplicateChannelsOrChannelGroups = "Duplicate Channels or Channel Groups";
88
internal static readonly string APNS2TopicEmpty = "Topic cannot be empty when APNS2 is selected";
9+
internal static readonly string UUIDMissing = "UUID misisng, please set it in the PNConfig.";
910
}
1011
}

PubNubUnity/Assets/PubNub/Helpers/Utility.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@ public static int CheckTimeoutValue(int value){
2525
}
2626
}
2727
#endif
28+
29+
public static void CheckUUID(string uuid){
30+
if (string.IsNullOrEmpty (uuid) || string.IsNullOrEmpty (uuid.Trim ())) {
31+
throw new PubNubException(CommonText.UUIDMissing);
32+
}
33+
}
2834

2935
public static bool CheckDictionaryForError(Dictionary<string, object> dictionary, string keyName){
3036
if(dictionary.ContainsKey(keyName) && dictionary[keyName].Equals(true)){

PubNubUnity/Assets/PubNub/Models/Server/BuildRequests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1300,6 +1300,7 @@ private static string TokenOrAuthKey(PubNubUnity pnInstance){
13001300
private static Uri BuildRestApiRequest<T> (List<string> urlComponents, PNOperationType type, string parameters, PubNubUnity pnInstance, Dictionary<string, string> queryParams)
13011301
{
13021302
string uuid = pnInstance.PNConfig.UUID;
1303+
Utility.CheckUUID(pnInstance.PNConfig.UUID);
13031304
bool ssl = pnInstance.PNConfig.Secure;
13041305
string origin = pnInstance.PNConfig.Origin;
13051306
int pubnubPresenceHeartbeatInSeconds = pnInstance.PNConfig.PresenceTimeout;

PubNubUnity/Assets/PubNub/PlayModeTests/PlayModeCommon.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ public static PNConfiguration SetPNConfig(bool useCipher, bool withPAM){
9090
pnConfiguration.Origin = Origin;
9191
pnConfiguration.SubscribeKey = SubscribeKey;
9292
pnConfiguration.PublishKey = PublishKey;
93+
pnConfiguration.UUID = PubNub.GenerateUUID();
9394
pnConfiguration.NonSubscribeTimeout = 30;
9495
if(withPAM){
9596
pnConfiguration.SubscribeKey = SubscribeKeyPAM;

PubNubUnity/Assets/PubNub/PubNub.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ private PubNub (PNConfiguration pnConfiguration, GameObject gameObjectRef, IJson
7272
this.jsonLibrary = jsonLibrary;
7373
this.gameObj = gameObjectRef;
7474
this.PNConfig = pnConfiguration;
75+
Utility.CheckUUID(this.PNConfig.UUID);
7576
PubNubUnityInitializationAfterCleanup();
7677
}
7778

@@ -102,6 +103,10 @@ public IJsonLibrary JsonLibrary{
102103
}
103104
}
104105

106+
public static string GenerateUUID(){
107+
return string.Format("pn-{0}", Guid.NewGuid ().ToString ());
108+
}
109+
105110
public void Reconnect(){
106111
PubNubUnityInitializationAfterCleanup();
107112
pnUnity.Reconnect();

PubNubUnity/Assets/PubNub/PubNubUnity/PNConfiguration.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,11 @@ public ushort ConcurrentNonSubscribeWorkers {
2929
private string uuid;
3030
public string UUID {
3131
get{
32-
if (string.IsNullOrEmpty (uuid) || string.IsNullOrEmpty (uuid.Trim ())) {
33-
uuid = string.Format("pn-{0}", Guid.NewGuid ().ToString ());
34-
}
35-
3632
return uuid;
3733
}
3834
set{
3935
uuid = value;
36+
Utility.CheckUUID(uuid);
4037
if(UUIDChanged!=null){
4138
UUIDChanged.Invoke(this, null);
4239
}

0 commit comments

Comments
 (0)