Skip to content

Commit 4376fc2

Browse files
Apply suggestions from code review
Co-authored-by: David Montague <[email protected]>
1 parent bfb4eef commit 4376fc2

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

pydantic_ai_slim/pydantic_ai/models/cohere.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,11 @@ def _map_messages(self, messages: list[ModelMessage]) -> list[ChatMessageV2]:
227227
tool_calls.append(self._map_tool_call(item))
228228
elif isinstance(item, ServerToolCallPart): # pragma: no cover
229229
# ServerToolCallPart represents a tool call from a remote server
230-
# Never returned from cohere
230+
# This is currently never returned from cohere
231231
pass
232232
elif isinstance(item, ServerToolReturnPart): # pragma: no cover
233233
# ServerToolReturnPart represents a tool return from a remote server
234-
# Never returned from cohere
234+
# This is currently never returned from cohere
235235
pass
236236
else:
237237
assert_never(item)

pydantic_ai_slim/pydantic_ai/models/gemini.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -626,11 +626,11 @@ def _content_model_response(m: ModelResponse) -> _GeminiContent:
626626
parts.append(_GeminiTextPart(text=item.content))
627627
elif isinstance(item, ServerToolCallPart): # pragma: no cover
628628
# Handle ServerToolCallPart the same as ToolCallPart
629-
# Never returned from gemini
629+
# This is currently never returned from gemini
630630
pass
631631
elif isinstance(item, ServerToolReturnPart): # pragma: no cover
632632
# Convert ServerToolReturnPart to a function response part
633-
# Never returned from gemini
633+
# This is currently never returned from gemini
634634
pass
635635
else:
636636
assert_never(item)

pydantic_ai_slim/pydantic_ai/models/google.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,10 +510,10 @@ def _content_model_response(m: ModelResponse) -> ContentDict:
510510
# parts.append({'text': item.content, 'thought': True})
511511
pass
512512
elif isinstance(item, ServerToolCallPart): # pragma: no cover
513-
# Never returned from google
513+
# This is currently never returned from google
514514
pass
515515
elif isinstance(item, ServerToolReturnPart): # pragma: no cover
516-
# Never returned from google
516+
# This is currently never returned from google
517517
pass
518518
else:
519519
assert_never(item)

pydantic_ai_slim/pydantic_ai/models/groq.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,11 +319,11 @@ def _map_messages(self, messages: list[ModelMessage]) -> list[chat.ChatCompletio
319319
continue
320320
elif isinstance(item, ServerToolCallPart): # pragma: no cover
321321
# ServerToolCallPart is handled separately in server-side tools
322-
# Never returned from groq
322+
# This is currently never returned from groq
323323
pass
324324
elif isinstance(item, ServerToolReturnPart): # pragma: no cover
325325
# ServerToolReturnPart is handled separately in server-side tools
326-
# Never returned from groq
326+
# This is currently never returned from groq
327327
pass
328328
else:
329329
assert_never(item)

pydantic_ai_slim/pydantic_ai/models/mistral.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,11 +505,11 @@ def _map_messages(self, messages: list[ModelMessage]) -> list[MistralMessages]:
505505
tool_calls.append(self._map_tool_call(part))
506506
elif isinstance(part, ServerToolCallPart): # pragma: no cover
507507
# Handle ServerToolCallPart the same as ToolCallPart
508-
# Never returned from mistral
508+
# This is currently never returned from mistral
509509
pass
510510
elif isinstance(part, ServerToolReturnPart): # pragma: no cover
511511
# For now, we'll add ServerToolReturnPart as text content
512-
# Never returned from mistral
512+
# This is currently never returned from mistral
513513
pass
514514
else:
515515
assert_never(part)

pydantic_ai_slim/pydantic_ai/models/openai.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ async def _map_messages(self, messages: list[ModelMessage]) -> list[chat.ChatCom
449449
pass
450450
elif isinstance(item, ToolCallPart):
451451
tool_calls.append(self._map_tool_call(item))
452-
# OpenAI doesn't return server tools calls.
452+
# OpenAI doesn't return server tool calls
453453
elif isinstance(item, (ServerToolCallPart, ServerToolReturnPart)): # pragma: no cover
454454
continue
455455
else:
@@ -897,7 +897,7 @@ async def _map_messages(
897897
openai_messages.append(responses.EasyInputMessageParam(role='assistant', content=item.content))
898898
elif isinstance(item, ToolCallPart):
899899
openai_messages.append(self._map_tool_call(item))
900-
# OpenAI doesn't return server tools calls.
900+
# OpenAI doesn't return server tool calls
901901
elif isinstance(item, (ServerToolCallPart, ServerToolReturnPart)):
902902
continue
903903
elif isinstance(item, ThinkingPart):

0 commit comments

Comments
 (0)