-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Open
Description
Description
Why are we defining a new string type? An alias is sufficient if we even need it, but I think str
is just fine. Also all PyTensor variables have a name
attribute we don't need to call getattr(variable, "name")
it may just be None
Line 61 in f6bfdfd
VarName = NewType("VarName", str) |
Lines 253 to 255 in f6bfdfd
def get_var_name(var) -> VarName: | |
"""Get an appropriate, plain variable name for a variable.""" | |
return VarName(str(getattr(var, "name", var))) |