Skip to content

Commit 425859b

Browse files
committed
Prioritize gemv/gerc over dot22scalar
The marked xfail test was failing because Ger wasn't introduced, not because of the complex dtype.
1 parent 58831af commit 425859b

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

pytensor/tensor/rewriting/blas.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -758,7 +758,7 @@ def local_dot22_to_ger_or_gemv(fgraph, node):
758758
ignore_newtrees=False,
759759
),
760760
"fast_run",
761-
position=15,
761+
position=11,
762762
)
763763

764764

@@ -903,7 +903,7 @@ def local_dot22_to_dot22scalar(fgraph, node):
903903
"local_dot22_to_dot22scalar",
904904
in2out(local_dot22_to_dot22scalar),
905905
"fast_run",
906-
position=11,
906+
position=12,
907907
)
908908

909909

tests/tensor/test_blas.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1903,17 +1903,9 @@ def test_f32_1_2(self):
19031903
def test_f64_4_5(self):
19041904
return self.given_dtype("float64", 4, 5, destructive=False)
19051905

1906-
@pytest.mark.xfail(
1907-
condition=config.floatX == "float32",
1908-
reason="GER from complex64 is not introduced in float32 mode",
1909-
)
19101906
def test_c64_7_1(self):
19111907
return self.given_dtype("complex64", 7, 1)
19121908

1913-
@pytest.mark.xfail(
1914-
raises=AssertionError,
1915-
reason="Unclear how this test was supposed to work with complex128",
1916-
)
19171909
def test_c128_1_9(self):
19181910
return self.given_dtype("complex128", 1, 9)
19191911

0 commit comments

Comments
 (0)