Skip to content

Conversation

@cetagostini
Copy link
Contributor

Description

Updates comments in funcify_Blockwise to avoid confusion about behaviour. Adds tests to verify correct behavior for these cases.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Updates comments in funcify_Blockwise to avoid confusion about behaviour. Adds tests to verify correct behavior for these cases.
@ricardoV94
Copy link
Member

Maybe all was good and PR isn't needed. @jessegrabowski do you have a snippet where things were failing without batch dims? It was from the linalg PR right?

@cetagostini cetagostini self-assigned this Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.70%. Comparing base (f83c05b) to head (36faee4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   81.68%   81.70%   +0.02%     
==========================================
  Files         244      246       +2     
  Lines       53549    53632      +83     
  Branches     9433     9438       +5     
==========================================
+ Hits        43741    43822      +81     
- Misses       7328     7329       +1     
- Partials     2480     2481       +1     
Files with missing lines Coverage Δ
pytensor/link/mlx/dispatch/blockwise.py 85.71% <ø> (+19.04%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jessegrabowski jessegrabowski merged commit a0225e1 into pymc-devs:main Nov 2, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants