Try null URL

Author: di

dev/environment

@@ -91,3 +91,6 @@ HELPDESK_BACKEND="warehouse.helpdesk.services.ConsoleHelpDeskService"
 
 # HELPDESK_NOTIFICATION_SERVICE_URL="https://..."
 HELPDESK_NOTIFICATION_BACKEND="warehouse.helpdesk.services.ConsoleAdminNotificationService"
+
+# XML-RPC Cache Service
+XMLRPC_CACHE_URL="null://"

tests/conftest.py

@@ -331,7 +331,7 @@ def get_app_config(database, nondefaults=None):
         "sessions.secret": "123456",
         "sessions.url": "redis://localhost:0/",
         "statuspage.url": "https://2p66nmmycsj3.statuspage.io",
-        "warehouse.xmlrpc.cache.url": "redis://localhost:0/",
+        "warehouse.xmlrpc.cache.url": "null://",
         "terms.revision": "initial",
     }
 

warehouse/config.py

@@ -230,13 +230,16 @@ def template_view(config, name, route, template, route_kw=None, view_kw=None):
 
 
 def maybe_set(settings, name, envvar, coercer=None, default=None):
+    print(name, envvar)
     if envvar in os.environ:
         value = os.environ[envvar]
+        print("\t", name, envvar, value)
         if coercer is not None:
             value = coercer(value)
         settings.setdefault(name, value)
     elif default is not None:
         settings.setdefault(name, default)
+    print("\t", name, envvar, "NOT SET")
 
 
 def maybe_set_compound(settings, base, name, envvar):
@@ -405,6 +408,7 @@ def configure(settings=None):
     maybe_set(settings, "token.two_factor.secret", "TOKEN_TWO_FACTOR_SECRET")
     maybe_set(settings, "token.remember_device.secret", "TOKEN_REMEMBER_DEVICE_SECRET")
     maybe_set_redis(settings, "warehouse.xmlrpc.cache.url", "REDIS_URL", db=4)
+    maybe_set(settings, "warehouse.xmlrpc.cache.url", "XMLRPC_CACHE_URL")
     maybe_set(
         settings,
         "warehouse.xmlrpc.client.ratelimit_string",

warehouse/legacy/api/xmlrpc/cache/__init__.py

@@ -60,6 +60,7 @@ def store_purge_keys(config, session, flush_context):
 
 @db.listens_for(db.Session, "after_commit")
 def execute_purge(config, session):
+    Exception(config)
     purges = session.info.pop("warehouse.legacy.api.xmlrpc.cache.purges", set())
 
     try:
@@ -96,9 +97,11 @@ def includeme(config):
 
     xmlrpc_cache_url_scheme = parse_url(xmlrpc_cache_url).scheme
     if xmlrpc_cache_url_scheme in ("redis", "rediss"):
+        print("*" * 80, "REDIS")
         xmlrpc_cache_class = RedisXMLRPCCache
     elif xmlrpc_cache_url_scheme in ("null"):
         xmlrpc_cache_class = NullXMLRPCCache
+        print("*" * 80, "NULL")
     else:
         raise ConfigurationError(
             f"Unknown XMLRPCCache scheme: {xmlrpc_cache_url_scheme}"

warehouse/legacy/api/xmlrpc/cache/services.py

@@ -49,6 +49,7 @@ def __init__(
 
     @classmethod
     def create_service(cls, context, request):
+        raise Exception("here")
         return cls(
             request.registry.settings.get("warehouse.xmlrpc.cache.url"),
             request.task(purge_tag).delay,
@@ -61,12 +62,15 @@ def create_service(cls, context, request):
         )
 
     def fetch(self, func, args, kwargs, key, tag, expires):
+        raise Exception("here")
         return self.redis_lru.fetch(func, args, kwargs, key, tag, expires)
 
     def purge(self, tag):
+        raise Exception("here")
         return self.redis_lru.purge(tag)
 
     def purge_tags(self, tags):
+        raise Exception("here")
         for tag in tags:
             self._purger(tag)