From 2c68e573a82594665b95ffae289efdd37d0dadc5 Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Thu, 26 Jun 2025 15:17:43 +0300 Subject: [PATCH 1/3] Remove outdated whitespace checks from patchcheck list --- getting-started/pull-request-lifecycle.rst | 4 ---- 1 file changed, 4 deletions(-) diff --git a/getting-started/pull-request-lifecycle.rst b/getting-started/pull-request-lifecycle.rst index f95ad6555..98182cc17 100644 --- a/getting-started/pull-request-lifecycle.rst +++ b/getting-started/pull-request-lifecycle.rst @@ -277,10 +277,6 @@ On *Windows* (after any successful build): The automated checklist runs through: -* Are there any whitespace problems in Python files? - (using :cpy-file:`Tools/patchcheck/reindent.py`) -* Are there any whitespace problems in C files? -* Are there any whitespace problems in the documentation? * Has the documentation been updated? * Has the test suite been updated? * Has an entry under ``Misc/NEWS.d/next`` been added? From bce17df1e38311194b602f8f5d117abde5ca3cf1 Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Thu, 26 Jun 2025 15:22:04 +0300 Subject: [PATCH 2/3] fixup! Remove outdated whitespace checks from patchcheck list --- getting-started/pull-request-lifecycle.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/getting-started/pull-request-lifecycle.rst b/getting-started/pull-request-lifecycle.rst index 98182cc17..7b66c23ef 100644 --- a/getting-started/pull-request-lifecycle.rst +++ b/getting-started/pull-request-lifecycle.rst @@ -286,9 +286,8 @@ The automated checklist runs through: * Has ``configure`` been regenerated, if necessary? * Has ``pyconfig.h.in`` been regenerated, if necessary? -The automated checks don't actually *answer* all of these -questions. Aside from the whitespace checks, the tool is -a memory aid for the various elements that can go into +The automated checks don't actually *answer* these questions. +The tool is a memory aid for the various elements that can go into making a complete pull request. From b6dae46fb4ad2fb36e341d793b6d4d86725bb6b0 Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Sat, 28 Jun 2025 13:18:24 +0300 Subject: [PATCH 3/3] Improve wording Co-authored-by: Ezio Melotti --- getting-started/pull-request-lifecycle.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/getting-started/pull-request-lifecycle.rst b/getting-started/pull-request-lifecycle.rst index 7b66c23ef..389b781fc 100644 --- a/getting-started/pull-request-lifecycle.rst +++ b/getting-started/pull-request-lifecycle.rst @@ -286,9 +286,8 @@ The automated checklist runs through: * Has ``configure`` been regenerated, if necessary? * Has ``pyconfig.h.in`` been regenerated, if necessary? -The automated checks don't actually *answer* these questions. -The tool is a memory aid for the various elements that can go into -making a complete pull request. +This will help you remember things that you need +to check before submitting a complete pull request. .. _good-commits: