Fix unreachable-break issue in dwio/rcfile/RcSerdeText.cpp +5 #12488
Conversation
Summary: LLVM has a warning `-Wunreachable-code-break` which identifies `break` statements that cannot be reached. These compromise readability, are misleading, and may identify bugs. This diff removes such statements. Such statements once existed to prevent accidental fallthroughs in switch statements. However, this is no longer necessary in C++17 because `[[fallthrough]]` is used to indicate intentional fallthroughs and we raise compilation errors for fallthroughs that are not annotated with `[[fallthrough]]` using `-Wimplicit-fallthrough`. For questions/comments, contact r-barnes. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: dtolnay Differential Revision: D78276018
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12488
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d82f6a1 with merge base 00491fd ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78276018 |
This PR needs a
|
Summary:
LLVM has a warning
-Wunreachable-code-breakwhich identifiesbreakstatements that cannot be reached. These compromise readability, are misleading, and may identify bugs. This diff removes such statements.Such statements once existed to prevent accidental fallthroughs in switch statements. However, this is no longer necessary in C++17 because
[[fallthrough]]is used to indicate intentional fallthroughs and we raise compilation errors for fallthroughs that are not annotated with[[fallthrough]]using-Wimplicit-fallthrough.For questions/comments, contact r-barnes.
Reviewed By: dtolnay
Differential Revision: D78276018