Fix no global destructor for strings in training modules #12521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathu
added
ciflow/trunk
ciflow/binaries
release notes: none
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12521
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled Jobs, 27 Pending, 6 Unrelated FailuresAs of commit 4e571e8 with merge base abd6eff ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
JacobSzwejbka
approved these changes
Jul 15, 2025
jathu
force-pushed
the
jathu/training-destructor
branch
from
6b44728 to
2e0a4fb
Compare
jathu
force-pushed
the
jathu/training-destructor
branch
from
2e0a4fb to
4e571e8
Compare
lucylq
pushed a commit
that referenced
this pull request
Jul 17, 2025
### Summary When building with [-Wglobal-constructors](https://clang.llvm.org/docs/DiagnosticsReference.html#wglobal-constructors), the non-static strings throw an error since they don't have a global destructor. This diff fixes that. ### Test plan CI + internal build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When building with -Wglobal-constructors, the non-static strings throw an error since they don't have a global destructor. This diff fixes that.
Test plan
CI + internal build