Skip to content

Outdated HIP/ROCm Build #477

@Spaarsh

Description

@Spaarsh

I am a Debian package developer working with the rocm-team.

The current HIP/ROCm build is outdated and does not lead to a successful build.

If one removes the strict version requirement of HIP 1.0, the next error encountered is:

CMake Error at cmake/Dependencies.cmake:168 (hip_include_directories):
  Unknown CMake command "hip_include_directories".

The current build configuration is using a legacy mode, which uses FindHIP.cmake while recent ROCm versions use hip-config.cmake and hip-lang-config.cmake. The entire HIP/ROCm build needs to be updated.

I have already patched this in the gloo package in Debian, which is currently under review.

It had to be built with USE_RCCL=OFF due to an issue with the rccl package in Debian. The package passes all the tests (that it is supposed to pass with RCCL OFF) and has been tested on an AMD Instinct MI210.

The logs can be found here.

The patch can be found here.

I shall make a PR in a short while to enable easier review of the changes made.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions