Update runner type to macos-14 in workflow #891
Conversation
Removing dependency on self-hosted macOS runners, in prep for migration to meta-pytorch org
meta-cla
bot
added
the
CLA Signed
|
Thanks for the PR @ZainRizvi! I'll let @scotts review as well, but I had some questions about this change.
|
| smoke-test-script: packaging/fake_smoke_test.py | ||
| runner-type: macos-m1-stable | ||
| runner-type: macos-14 | ||
| setup-miniconda: true |
There was a problem hiding this comment.
Why is miniconda needed here?
There was a problem hiding this comment.
The pytorch/test-infra/.github/workflows/build_wheels_macos.yml@main workflow expects miniconda to be pre-installed on the host. All our self-hosted mac runners have miniconda pre-installed on them, so this flag wasn't needed. The github hosted runners don't have it though, so we pass in this flag to install it.
|
Hey @Dan-Flores this should actually give you better availability for the mac runners, since the jobs will be moving to the github hosted macos runners instead of using the self-hosted ones that we have a fixed supply of and do not autoscale. Most immediately, you'll likely notice that these runners will have much lower queue times. Linux/windows self-hosted runners are auto-scaled and will not be changed. |
Removing dependency on self-hosted macOS runners, in prep for migration to meta-pytorch org