Disable ffprobe test internally #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@Dan-Flores has exported this pull request. If you are a Meta employee, you can view the originating diff in D82378431. |
Dan-Flores
added a commit
to Dan-Flores/torchcodec
that referenced
this pull request
Sep 14, 2025
Summary: Tests related to `custom_frame_mappings` that utilize ffprobe should be skipped internally as ffprobe is not available. In addition to adding the `pytest.skip` decorator to these tests, I removed `custom_frame_mapping` generation from `pytest.mark.parametrize` in `test_custom_frame_mappings_init_fails` to allow tests to run. Reviewed By: scotts Differential Revision: D82378431
Dan-Flores
force-pushed
the
export-D82378431
branch
from
44d40a1 to
0dcd99e
Compare
|
@Dan-Flores has exported this pull request. If you are a Meta employee, you can view the originating diff in D82378431. |
Dan-Flores
added a commit
to Dan-Flores/torchcodec
that referenced
this pull request
Sep 14, 2025
Summary: Tests related to `custom_frame_mappings` that utilize ffprobe should be skipped internally as ffprobe is not available. In addition to adding the `pytest.skip` decorator to these tests, I removed `custom_frame_mapping` generation from `pytest.mark.parametrize` in `test_custom_frame_mappings_init_fails` to allow tests to run. Reviewed By: scotts Differential Revision: D82378431
Dan-Flores
force-pushed
the
export-D82378431
branch
from
0dcd99e to
5cb9e7d
Compare
|
@Dan-Flores has exported this pull request. If you are a Meta employee, you can view the originating diff in D82378431. |
Dan-Flores
added a commit
to Dan-Flores/torchcodec
that referenced
this pull request
Sep 14, 2025
Summary: Tests related to `custom_frame_mappings` that utilize ffprobe should be skipped internally as ffprobe is not available. In addition to adding the `pytest.skip` decorator to these tests, I removed `custom_frame_mapping` generation from `pytest.mark.parametrize` in `test_custom_frame_mappings_init_fails` to allow tests to run. Reviewed By: scotts Differential Revision: D82378431
Dan-Flores
force-pushed
the
export-D82378431
branch
from
5cb9e7d to
fd8f09a
Compare
|
@Dan-Flores has exported this pull request. If you are a Meta employee, you can view the originating diff in D82378431. |
Dan-Flores
added a commit
to Dan-Flores/torchcodec
that referenced
this pull request
Sep 14, 2025
Summary: Tests related to `custom_frame_mappings` that utilize ffprobe should be skipped internally as ffprobe is not available. In addition to adding the `pytest.skip` decorator to these tests, I removed `custom_frame_mapping` generation from `pytest.mark.parametrize` in `test_custom_frame_mappings_init_fails` to allow tests to run. Reviewed By: scotts Differential Revision: D82378431
Dan-Flores
force-pushed
the
export-D82378431
branch
from
fd8f09a to
f1f27d5
Compare
|
@Dan-Flores has exported this pull request. If you are a Meta employee, you can view the originating diff in D82378431. |
Summary: Tests related to `custom_frame_mappings` that utilize ffprobe should be skipped internally as ffprobe is not available. In addition to adding the `pytest.skip` decorator to these tests, I removed `custom_frame_mapping` generation from `pytest.mark.parametrize` in `test_custom_frame_mappings_init_fails` to allow tests to run. Reviewed By: scotts Differential Revision: D82378431
Dan-Flores
force-pushed
the
export-D82378431
branch
from
f1f27d5 to
458877f
Compare
|
@Dan-Flores has exported this pull request. If you are a Meta employee, you can view the originating diff in D82378431. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Tests related to
custom_frame_mappingsthat utilize ffprobe should be skipped internally as ffprobe is not available.In addition to adding the
pytest.skipdecorator to these tests, I removedcustom_frame_mappinggeneration frompytest.mark.parametrizeintest_custom_frame_mappings_init_failsto allow tests to run.Reviewed By: scotts
Differential Revision: D82378431