Fix skipped tests for test_model_parallel_gloo #3196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78355780 |
Summary: `ModelParallelStateDictTestGloo: test_optimizer_load_state_dict` test is frequently getting skipped because some of the examples generated by the framework hits the skipTest() condition, which is: - Using CPU with UVM Kernel modes (FUSED_UVM, FUSED_UVM_CACHING) While iterating through each generated example, the test will consider the entire test "skipped" if any of them hit the skipTest condition. Instead, we should just skip the example so that hypothesis can generate the next example which is valid. Differential Revision: D78355780
jeffkbkim
force-pushed
the
export-D78355780
branch
from
9744136 to
c5316f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78355780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ModelParallelStateDictTestGloo: test_optimizer_load_state_dicttest is frequently getting skipped because some of the examples generated by the framework hits the skipTest() condition, which is:While iterating through each generated example, the test will consider the entire test "skipped" if any of them hit the skipTest condition.
Instead, we should just skip the example so that hypothesis can generate the next example which is valid.
Differential Revision: D78355780