Skip to content

Migrate fsdp1 -> fsdp2 in Tensor Parallelism Tutorial #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

wwwjn
Copy link
Contributor

@wwwjn wwwjn commented Jul 15, 2025

Fixes Pytorch Tutorial Audit - Tensor Parallelism Tutorial

Description

Migrate from FSDP1 to FSDP2 in Tensor Parallelism tutorial
Related changes in examples repo: pytorch/examples#1372

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

Copy link

pytorch-bot bot commented Jul 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3464

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 55493b2 with merge base d5cd489 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the cla signed label Jul 15, 2025
@svekars svekars added the tutorials_audit used on tutorial audit PRs label Jul 15, 2025
@wwwjn
Copy link
Contributor Author

wwwjn commented Jul 15, 2025

cc @tianyu-l

Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this!

@svekars svekars merged commit 755434d into pytorch:main Jul 16, 2025
24 checks passed
svekars pushed a commit that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed tutorials_audit used on tutorial audit PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants