Skip to content

Commit 2421209

Browse files
enabled logger for page objects (#88)
1 parent 197c7f3 commit 2421209

File tree

5 files changed

+56
-53
lines changed

5 files changed

+56
-53
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
88
:beetle: - bugfix
99
:x: - deprecation
1010

11+
## [0.39.0]
12+
- :rocket: enabled logger for page objects
13+
1114
## [0.38.0]
1215
- :rocket: added _I close current tab_ step
1316

package-lock.json

Lines changed: 43 additions & 43 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@qavajs/steps-playwright",
3-
"version": "0.38.0",
3+
"version": "0.39.0",
44
"description": "steps to interact with playwright",
55
"main": "./index.js",
66
"scripts": {
@@ -26,16 +26,16 @@
2626
"homepage": "https://github.com/qavajs/steps-playwright#readme",
2727
"devDependencies": {
2828
"@cucumber/cucumber": "^10.0.1",
29-
"@qavajs/cli": "^0.30.1",
29+
"@qavajs/cli": "^0.32.0",
3030
"@qavajs/console-formatter": "^0.6.0",
31-
"@qavajs/html-formatter": "^0.14.3",
31+
"@qavajs/html-formatter": "^0.15.2",
3232
"@qavajs/memory": "^1.6.2",
33-
"@qavajs/po-playwright": "^0.11.1",
33+
"@qavajs/po-playwright": "^0.11.2",
3434
"@qavajs/webstorm-adapter": "^8.0.0",
35-
"@types/chai": "^4.3.9",
36-
"@types/express": "^4.17.20",
35+
"@types/chai": "^4.3.10",
36+
"@types/express": "^4.17.21",
3737
"@vitest/coverage-v8": "^0.34.6",
38-
"electron": "^27.0.2",
38+
"electron": "^27.0.4",
3939
"express": "^4.18.2",
4040
"ts-node": "^10.9.1",
4141
"typescript": "^5.2.2",

src/hooks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Before(async function () {
6464
? browser.firstWindow()
6565
: await context.newPage();
6666
global.driver = global.browser;
67-
po.init(page, { timeout: config.driverConfig.timeout.present });
67+
po.init(page, { timeout: config.driverConfig.timeout.present, logger: this });
6868
po.register(config.pageObject);
6969
this.log(`driver instance started:\n${JSON.stringify(config.driverConfig, null, 2)}`);
7070
});

src/validations.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Then } from '@cucumber/cucumber';
22
import { getValue, getElement, getConditionWait } from './transformers';
33
import { getValidation } from '@qavajs/validation';
4-
import {Locator} from 'playwright';
4+
import { Locator } from 'playwright';
55

66
/**
77
* Verify element condition
@@ -165,7 +165,7 @@ Then('I expect every element in {string} collection {playwrightConditionWait}',
165165
* @param {string} validationType - validation
166166
* @param {string} value - expected result
167167
* @example I expect text of every element in 'Search Results' collection equals to 'google'
168-
* @example I expect text of every element in 'Search Results' collection does not contain 'yandex'
168+
* @example I expect text of every element in 'Search Results' collection does not contain 'google'
169169
*/
170170
Then(
171171
'I expect text of every element in {string} collection {playwrightValidation} {string}',

0 commit comments

Comments
 (0)