Skip to content

Commit fe8a4ed

Browse files
etienne-lmsapalos
authored andcommitted
tee: optee: discover services dependent on tee-supplicant
Makes OP-TEE to enumerate also services depending on tee-supplicant support in U-Boot. This change allows OP-TEE services like fTPM TA to be discovered and get a TPM device registered in U-Boot. Signed-off-by: Etienne Carriere <[email protected]> Reviewed-by: Ilias Apalodimas <[email protected]> Reviewed-by: Jens Wiklander <[email protected]> Signed-off-by: Ilias Apalodimas <[email protected]>
1 parent 476a3d5 commit fe8a4ed

File tree

1 file changed

+23
-9
lines changed

1 file changed

+23
-9
lines changed

drivers/tee/optee/core.c

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -102,13 +102,14 @@ static int bind_service_list(struct udevice *dev, struct tee_shm *service_list,
102102
return 0;
103103
}
104104

105-
static int __enum_services(struct udevice *dev, struct tee_shm *shm, size_t *shm_size, u32 tee_sess)
105+
static int __enum_services(struct udevice *dev, struct tee_shm *shm, size_t *shm_size, u32 tee_sess,
106+
unsigned int pta_cmd)
106107
{
107108
struct tee_invoke_arg arg = { };
108109
struct tee_param param = { };
109110
int ret = 0;
110111

111-
arg.func = PTA_CMD_GET_DEVICES;
112+
arg.func = pta_cmd;
112113
arg.session = tee_sess;
113114

114115
/* Fill invoke cmd params */
@@ -118,7 +119,7 @@ static int __enum_services(struct udevice *dev, struct tee_shm *shm, size_t *shm
118119

119120
ret = tee_invoke_func(dev, &arg, 1, &param);
120121
if (ret || (arg.ret && arg.ret != TEE_ERROR_SHORT_BUFFER)) {
121-
dev_err(dev, "PTA_CMD_GET_DEVICES invoke function err: 0x%x\n", arg.ret);
122+
dev_err(dev, "Enumeration command 0x%x failed: 0x%x\n", pta_cmd, arg.ret);
122123
return -EINVAL;
123124
}
124125

@@ -127,12 +128,13 @@ static int __enum_services(struct udevice *dev, struct tee_shm *shm, size_t *shm
127128
return 0;
128129
}
129130

130-
static int enum_services(struct udevice *dev, struct tee_shm **shm, size_t *count, u32 tee_sess)
131+
static int enum_services(struct udevice *dev, struct tee_shm **shm, size_t *count, u32 tee_sess,
132+
unsigned int pta_cmd)
131133
{
132134
size_t shm_size = 0;
133135
int ret;
134136

135-
ret = __enum_services(dev, NULL, &shm_size, tee_sess);
137+
ret = __enum_services(dev, NULL, &shm_size, tee_sess, pta_cmd);
136138
if (ret)
137139
return ret;
138140

@@ -142,7 +144,7 @@ static int enum_services(struct udevice *dev, struct tee_shm **shm, size_t *coun
142144
return ret;
143145
}
144146

145-
ret = __enum_services(dev, *shm, &shm_size, tee_sess);
147+
ret = __enum_services(dev, *shm, &shm_size, tee_sess, pta_cmd);
146148
if (!ret)
147149
*count = shm_size / sizeof(struct tee_optee_ta_uuid);
148150

@@ -174,20 +176,32 @@ static int bind_service_drivers(struct udevice *dev)
174176
struct tee_shm *service_list = NULL;
175177
size_t service_count;
176178
u32 tee_sess;
177-
int ret;
179+
int ret, ret2;
178180

179181
ret = open_enum_session(dev, &tee_sess);
180182
if (ret)
181183
return ret;
182184

183-
ret = enum_services(dev, &service_list, &service_count, tee_sess);
185+
ret = enum_services(dev, &service_list, &service_count, tee_sess,
186+
PTA_CMD_GET_DEVICES);
184187
if (!ret)
185188
ret = bind_service_list(dev, service_list, service_count);
186189

187190
tee_shm_free(service_list);
191+
192+
ret2 = enum_services(dev, &service_list, &service_count, tee_sess,
193+
PTA_CMD_GET_DEVICES_SUPP);
194+
if (!ret2)
195+
ret2 = bind_service_list(dev, service_list, service_count);
196+
197+
tee_shm_free(service_list);
198+
188199
tee_close_session(dev, tee_sess);
189200

190-
return ret;
201+
if (ret)
202+
return ret;
203+
204+
return ret2;
191205
}
192206

193207
/**

0 commit comments

Comments
 (0)