-
Notifications
You must be signed in to change notification settings - Fork 406
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Related to the issue: quantopian/zipline#2700
As @richafrank mentioned on the issue linked above is the module-level variable start_default in trading_calendars\trading_calendar.py being '1990-01-01'.
In my opinion '1990-01-01' seems somewhat arbitrary. As far as my understanding goes, the only reason it is '1990-01-01' and not earlier is to avoid caches to take up too much memory.
Disadvantages of this approach:
- The open-issue linked above
- PrecomputedTradingCalendar uses its own start/end dates and some of them start earlier than '1990-01-01'
- The cached data frame does not take that much memory anyway? (but I might be utterly wrong here)
Possible solutions off the top of my head:
- Change 'start_default' to something much earlier
- Add exchange specific
start_defaultandend_default, this is consistent with how PrecomputedTradingCalendar behaves - Add a way for end-user to change
start_defaultandend_default(e.g. storestart_defaultandend_defaultin a mutable container than give access to end-user).
gerrymanoim
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request