-
Notifications
You must be signed in to change notification settings - Fork 3k
Closed
Closed
Copy link
Labels
area/reactive-sql-clientsgood first issueGood for newcomersGood for newcomerskind/enhancementNew feature or requestNew feature or request
Milestone
Description
Description
quarkus.datasource.reactive.cache-prepared-statement defaults to false, because it's only supported for some databases.
This creates a performance disadvantage for reactive compared to JDBC for databases that do support caching prepared statement; e.g. the PostgreSQL JDBC driver caches prepared statements by default (preparedStatementCacheQueries defaults to 256), and @franz1981 tells us this has a sizeable impact on benchmarks.
We should:
- Make
cachePreparedStatementsanOptional<Boolean>. - Remove
@WithDefaultfrom that field. - Add
@ConfigDocDefaultto explain what the default is:trueif supported (PostgreSQL/MySQL/MariaDB/DB2),falseotherwise. - Handle the default with a
Optional#orElsein relevant places, i.e. where the DB-specific code forwards the setting. - Test, at least manually, that the default is effective.
Implementation ideas
No response
franz1981 and tsegismont
Metadata
Metadata
Assignees
Labels
area/reactive-sql-clientsgood first issueGood for newcomersGood for newcomerskind/enhancementNew feature or requestNew feature or request