Godot 4.2 / .net6 port #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you, definitely better than nothing |
Treer
commented
Feb 1, 2023
| /// This is a hack until we can fix the code generated by GodotPluginsInitializerGenerator to specify it means System.Console not this Console | ||
| /// https://github.com/godotengine/godot/pull/72434 | ||
| /// </summary> | ||
| public static TextWriter Error => System.Console.Error; |
Author
There was a problem hiding this comment.
Damn that was quick, the Godot devs have fixed it already!
FuncRefs are replaced by Callables, and there's a change to array syntax The demo projects will still need attention, but the console works in Godot 4.
Renames call() to invoke_call() to avoid "The function signature doesn't match the parent" errors. Since gdscript doesn't support function overloading, classes can no longer have a method named "call" because the Object class has one.
Treer
added a commit
to Treer/WorldWanderer
that referenced
this pull request
Jan 21, 2024
Pulls 4.2 fixes for quentincaffeino/godot-console from quentincaffeino/godot-console#108
|
This crashes for me due to Iterator.gd still using the .call() function |
commit missing changes that were supposed to be part of a7d9232
Author
|
thanks, my files locally had the change but I somehow hadn't pushed it here, and wouldn't have noticed |
I'm not sure whether it's due to changes in Godot version, but the console text edit field kept failing to have focus unless you clicked in it. These changes seem to be sufficient to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also addresses #104
This PR might age like milk and need to be dropped as refinements continue in Godot 4, but today it works 😄Godot 4.0-stable only took minor tweaks from the initial Godot 4 Beta-16 pull request