fix(qf): Implement proper context cancellation on read/write loops and stop loop spin on read loop error #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle logon error
This commit enhances the handling of read/write loops by following proper context cancellation. It fixes a goroutine leak found before, and ensures that the run loop does not cycle continuously through disconnect on run failures, but only once per connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with issues around the context cancellation that meant that we failed to properly close down goroutines (goroutine leaks).
This PR also fixes a bug within the write loop that made it exit too early and left the engine unable to action logout + disconnect on teardown.
Finally, this PR also clears the closed read channel after processing the first close. This gives us the ability to disconnect and close the context only after the session has ended and we are safe to do so.