Skip to content

Commit 8131ec7

Browse files
committed
Ensure base image of the same tag is used for demo image
1 parent b4afd4e commit 8131ec7

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
fi
3737
echo "app_version=${GITHUB_REF:10}" >>$GITHUB_OUTPUT
3838
39-
- name: Build and publish base container
39+
- name: Build and publish base image
4040
uses: elgohr/Publish-Docker-Github-Action@v5
4141
if: github.event_name != 'pull_request'
4242
with:
@@ -45,15 +45,16 @@ jobs:
4545
password: ${{ secrets.DOCKER_HUB_PASSWORD }}
4646
tags: "${{ steps.get_tag.outputs.tag }}"
4747

48-
- name: Build and publish demo container
48+
- name: Build and publish demo image
4949
uses: elgohr/Publish-Docker-Github-Action@v5
5050
if: github.event_name != 'pull_request'
5151
env:
5252
QWC2_URL: https://github.com/qgis/qwc2-demo-app/releases/download/${{ steps.get_tag.outputs.app_version }}/qwc2-demo-app.zip
53+
BASE_IMAGE_VERSION: ${{ steps.get_tag.outputs.app_version }}
5354
with:
5455
name: sourcepole/qwc-map-viewer-demo
5556
username: ${{ secrets.DOCKER_HUB_USER }}
5657
password: ${{ secrets.DOCKER_HUB_PASSWORD }}
5758
tags: "${{ steps.get_tag.outputs.tag }}"
5859
dockerfile: Dockerfile-qwc2-app
59-
buildargs: "QWC2_URL"
60+
buildargs: QWC2_URL,BASE_IMAGE_VERSION

Dockerfile-qwc2-app

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
FROM sourcepole/qwc-map-viewer-base:latest
1+
ARG BASE_IMAGE_VERSION=latest-lts
2+
FROM sourcepole/qwc-map-viewer-base:$BASE_IMAGE_VERSION
23

34
ARG QWC2_URL
45
# Optional token for download with authorization

0 commit comments

Comments
 (0)