chore(qwik-nx): v3 (#239)

* chore(qwik-nx): migrate to nx v20

* feat(qwik-nx): make directory a required option for generators

* test(qwik-nx): update tests

* chore(repo): bump deps again

* test(qwik-nx): update e2e

* feat(qwik-nx): add "root" prop migration

* refactor(qwik-nx): params cleanup

* refactor(repo): eslint updates

Author: dmitry-stepanenko

.eslintrc.json

@@ -30,7 +30,7 @@
         "@typescript-eslint/no-non-null-assertion": "off",
         "unused-imports/no-unused-imports": "error",
         "no-duplicate-imports": "error",
-        "unused-imports/no-unused-vars": "error",
+        "@typescript-eslint/no-unused-vars": "error",
         "@typescript-eslint/naming-convention": [
           "error",
           {
@@ -41,13 +41,16 @@
             "selector": "enumMember",
             "format": ["PascalCase"]
           }
-        ]
+        ],
+        "no-extra-semi": "error"
       }
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript"],
-      "rules": {}
+      "rules": {
+        "no-extra-semi": "error"
+      }
     },
     {
       "files": [

.github/actions/test/action.yml

@@ -20,7 +20,7 @@ runs:
 
     - name: Test
       shell: bash
-      run: npx nx affected --target=test --base=${{ env.NX_BASE }} --head=HEAD
+      run: npx nx affected --target=test --base=${{ env.NX_BASE }} --head=HEAD ${{ runner.os == 'Windows' && '--maxWorkers=1' }}
 
     - name: E2E Tests
       # TODO: temporary disabled e2e on windows

.gitignore

@@ -43,4 +43,7 @@ Thumbs.db
 
 # Nx
 .nx/cache
-migrations.json
+.nx/workspace-data
+migrations.json
+vite.config.*.timestamp*
+vitest.config.*.timestamp*

.prettierignore

@@ -3,4 +3,5 @@
 /dist
 /coverage
 CHANGELOG.md
-/.nx/cache
+/.nx/cache
+/.nx/workspace-data

e2e/qwik-nx-e2e/tests/application-basic-behavior.suite.ts

@@ -21,7 +21,7 @@ import { names } from '@nx/devkit';
 export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
   const isPreset = generator === 'preset';
   const appPathPrefix = isPreset ? 'apps/' : '';
-  const libPathPrefix = isPreset ? 'libs/' : '';
+  const libPathPrefix = '';
   const devServerPort = 4212;
   const previewServerPort = 4232;
   describe(`Basic behavior with ${generator} generator`, () => {
@@ -77,7 +77,7 @@ export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
       'should create qwik-nx',
       async () => {
         const result = await runNxCommandAsync(`build ${project}`);
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Running type check for the "${project}"..`
         );
         expect(
@@ -91,7 +91,7 @@ export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
             .join('')
             .replace(/\n|\s/g, '')
         );
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Successfully ran target build for project ${project}`
         );
         expect(() =>
@@ -167,7 +167,7 @@ export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
       'unit tests should pass in the created app',
       async () => {
         const result = await runNxCommandAsync(`test ${project}`);
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Successfully ran target test for project ${project}`
         );
       },
@@ -186,7 +186,7 @@ export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
         const result = await runNxCommandAsync(`test ${project}`, {
           silenceError: true,
         });
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Running target test for project ${project} failed`
         );
       },
@@ -211,7 +211,7 @@ export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
             .join('')
             .replace(/\n|\s/g, '')
         );
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Successfully ran target build for project ${project}`
         );
       },

e2e/qwik-nx-e2e/tests/chore.spec.ts

@@ -23,10 +23,10 @@ describe('misc checks', () => {
       expect(packageJson.dependencies).toBeUndefined();
       expect(packageJson.devDependencies).toBeUndefined();
       expect(packageJson.peerDependencies).toEqual({
-        '@nx/devkit': '^17.0.0 || ^18.0.0 || ^19.0.0',
-        '@nx/js': '^17.0.0 || ^18.0.0 || ^19.0.0',
-        '@nx/eslint': '^17.0.0 || ^18.0.0 || ^19.0.0',
-        '@nx/vite': '^17.0.0 || ^18.0.0 || ^19.0.0',
+        '@nx/devkit': '^20.0.0',
+        '@nx/js': '^20.0.0',
+        '@nx/eslint': '^20.0.0',
+        '@nx/vite': '^20.0.0',
       });
     },
     DEFAULT_E2E_TIMEOUT

e2e/qwik-nx-e2e/tests/micro-frontends.spec.ts

@@ -57,7 +57,7 @@ describe('Micro-frontends e2e', () => {
     async () => {
       const checkProject = async (name: string) => {
         const result = await runNxCommandAsync(`build ${name}`);
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Successfully ran target build for project ${name}`
         );
         expect(() =>
@@ -152,7 +152,7 @@ describe('Micro-frontends e2e', () => {
         `generate qwik-nx:remote ${remote3} --host=${project} --port=5176 --no-interactive`
       );
       const result = await runNxCommandAsync(`build ${remote3}`);
-      expect(result.stdout).toContain(
+      expect(stripConsoleColors(result.stdout)).toContain(
         `Successfully ran target build for project ${remote3}`
       );
       expect(() =>

e2e/qwik-nx-e2e/tests/qwik-nx-cloudflare.spec.ts

@@ -11,6 +11,7 @@ import {
   killPort,
   killPorts,
   DEFAULT_E2E_TIMEOUT,
+  stripConsoleColors,
 } from '@qwikifiers/e2e/utils';
 
 const CLOUDFLARE_PREVIEW_PORT = 4173;
@@ -49,7 +50,7 @@ describe('qwik nx cloudflare generator', () => {
       'should be able to successfully build the application',
       async () => {
         const result = await runNxCommandAsync(`build-cloudflare ${project}`);
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Successfully ran target build for project ${project}`
         );
         expect(() =>

e2e/qwik-nx-e2e/tests/qwik-nx-netlify.spec.ts

@@ -11,6 +11,7 @@ import {
   killPort,
   killPorts,
   DEFAULT_E2E_TIMEOUT,
+  stripConsoleColors,
 } from '@qwikifiers/e2e/utils';
 
 const NETLIFY_PREVIEW_PORT = 8888;
@@ -41,7 +42,7 @@ describe('qwik nx netlify generator', () => {
       'should be able to successfully build the application',
       async () => {
         const result = await runNxCommandAsync(`build-netlify ${project}`);
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Successfully ran target build for project ${project}`
         );
         expect(() =>

e2e/qwik-nx-e2e/tests/qwik-nx-vite.spec.ts

@@ -15,6 +15,7 @@ import {
   removeFile,
   killPorts,
   DEFAULT_E2E_TIMEOUT,
+  stripConsoleColors,
 } from '@qwikifiers/e2e/utils';
 
 describe('qwikNxVite plugin e2e', () => {
@@ -109,7 +110,7 @@ describe('qwikNxVite plugin e2e', () => {
       'should be able to successfully build the application',
       async () => {
         const result = await runNxCommandAsync(`build ${project}`);
-        expect(result.stdout).toContain(
+        expect(stripConsoleColors(result.stdout)).toContain(
           `Successfully ran target build for project ${project}`
         );
         expect(() =>