-
Notifications
You must be signed in to change notification settings - Fork 152
feat(styled kit): tailwind v4 update #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
commit: |
8958788
to
73be2e8
Compare
73be2e8
to
5d61f34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will submit this to potential alpha testers before merging as this is a pretty big change. |
What is it?
Why is it needed?
Closes #1115.
npx @tailwindcss/upgrade
!important
attribute on hidden elements prevented the component from calculating the offsetHeight of the CollapsibleContent (see v4 preflight adds !important on [hidden] attribute, unexpectedly preventing override tailwindlabs/tailwindcss#18653 (comment) and Add details abouthidden
attribute preflight rules tailwindlabs/tailwindcss.com#2321)Upgrade guide:
npx @tailwindcss/upgrade
script and let it do most of the work for you@source “../../../path/to/your/components“;
Checklist:
pnpm change
and documented my changes