-
Notifications
You must be signed in to change notification settings - Fork 4k
WIP: DO NOT MERGE Su aws/replace httpc with gun fmt ets table #14565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimonUnge
wants to merge
6
commits into
su_aws/replace_httpc_with_gun_fmt
Choose a base branch
from
su_aws/replace_httpc_with_gun_fmt_ets_table
base: su_aws/replace_httpc_with_gun_fmt
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: DO NOT MERGE Su aws/replace httpc with gun fmt ets table #14565
SimonUnge
wants to merge
6
commits into
su_aws/replace_httpc_with_gun_fmt
from
su_aws/replace_httpc_with_gun_fmt_ets_table
+483
−931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mq/rabbitmq-server into su_aws/replace_httpc_with_gun_fmt
Collaborator
the-mikedavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor things - I'm excited to get rid of the gen_server!
Collaborator
Author
|
@the-mikedavis its only to merge this into 'our' other branch for now, not into main. |
Collaborator
Author
|
@michaelklishin I hope its OK that I merge this into just another of our branches (not into main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
A pull request that doesn't explain why the change was made has a much lower chance of being accepted.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.