fix(setup): Ensure yq is on remote host

YQ is more necessary on the remote host than the local host that runs
the hyperconverged-lab script, so warn about it not getting installed
locally but fail if not present on the remote host.

Author: LukeRepko

bin/install-keystone.sh

@@ -42,23 +42,6 @@ fi
 
 echo "Found version for $SERVICE_NAME_DEFAULT: $SERVICE_VERSION"
 
-# Debug: Check yq availability before using it
-echo "=== YQ DEBUG INFO ==="
-echo "PATH: $PATH"
-if command -v yq &> /dev/null; then
-    echo "yq found at: $(command -v yq)"
-    echo "yq version: $(yq --version)"
-    echo "====================="
-else
-    echo "ERROR: yq command not found in PATH"
-    echo "Checking common locations:"
-    ls -la /usr/local/bin/yq 2>/dev/null || echo "  /usr/local/bin/yq: not found"
-    ls -la /usr/bin/yq 2>/dev/null || echo "  /usr/bin/yq: not found"
-    echo "====================="
-    echo "Cannot continue without yq. Exiting."
-    exit 1
-fi
-
 # Load chart metadata from custom override YAML if defined
 for yaml_file in "${SERVICE_CUSTOM_OVERRIDES}"/*.yaml; do
     if [ -f "$yaml_file" ]; then

scripts/hyperconverged-lab.sh

@@ -8,11 +8,13 @@ RUN_EXTRAS=0
 INCLUDE_LIST=()
 EXCLUDE_LIST=()
 
+# yq installation constants
+YQ_VERSION="v4.2.0"
+YQ_BINARY="yq_linux_amd64"
+
 function installYq() {
-    export VERSION=v4.2.0
-    export BINARY=yq_linux_amd64
-    if wget https://github.com/mikefarah/yq/releases/download/${VERSION}/${BINARY}.tar.gz -O - | tar xz && sudo mv ${BINARY} /usr/local/bin/yq; then
-        echo "Successfully installed yq version ${VERSION}"
+    if wget https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/${YQ_BINARY}.tar.gz -O - | tar xz && sudo mv ${YQ_BINARY} /usr/local/bin/yq; then
+        echo "Successfully installed yq version ${YQ_VERSION}"
         return 0
     else
         echo "Failed to install yq"
@@ -24,8 +26,7 @@ function installYq() {
 if ! yq --version 2> /dev/null; then
   echo "yq is not installed. Attempting to install yq"
   if ! installYq; then
-    echo "Unable to proceed without yq. Exiting."
-    exit 1
+    echo "[WARNING] Failed to install yq locally"
   fi
 fi
 
@@ -437,6 +438,19 @@ if [ ! -d "/etc/genestack" ]; then
   sudo chown \${USER}:\${USER} -R /etc/genestack
 fi
 
+# Install yq on the remote host if not already present
+if ! command -v yq &> /dev/null; then
+  echo "Installing yq on remote host..."
+  if wget https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/${YQ_BINARY}.tar.gz -O - | tar xz && sudo mv ${YQ_BINARY} /usr/local/bin/yq; then
+    echo "Successfully installed yq version ${YQ_VERSION} on remote host"
+  else
+    echo "Failed to install yq on remote host"
+    exit 1
+  fi
+else
+  echo "yq already available on remote host: \$(yq --version)"
+fi
+
 # We need to clobber the sample or else we get a bogus LB vip
 cat > /etc/genestack/manifests/metallb/metallb-openstack-service-lb.yml <<EOF
 ---