fix(setup): Improve yq installation and handling

Add verbosity to the wget command so we can troubleshoot download
failures if encountered more easily, as well as very clear and
concise messaging around whether or not yq really got installed.

YQ is more necessary on the remote host than the local host that runs
the hyperconverged-lab script, so warn about it not getting installed
locally but fail if not present on the remote host as it's a
pre-requisite to running many install scripts.

Author: LukeRepko

bin/setup-openstack.sh

@@ -17,7 +17,7 @@ function waitErator() {
     local start_time
     start_time=$(date +%s)
     local timeout_seconds=$((30 * 60))  # 30 minutes
-    
+
     while [ ${#pids[@]} -gt 0 ]; do
         # Check for timeout
         local current_time
@@ -33,15 +33,15 @@ function waitErator() {
             echo "==== PROCESS TIMEOUT ====================================="
             exit 1
         fi
-        
+
         for pid in "${!pids[@]}"; do
             # Check if process is still running
             if ! kill -0 ${pid} 2>/dev/null; then
                 # Process finished, check exit status
                 # Use || to prevent set -e from killing the script before we can log the failure
                 wait ${pid} || local exit_code=$?
                 exit_code=${exit_code:-0}
-                
+
                 if [ $exit_code -ne 0 ]; then
                     echo "==== PROCESS FAILED ====================================="
                     echo "Command: ${pid_commands[$pid]}"
@@ -57,7 +57,7 @@ function waitErator() {
         done
         sleep 1
     done
-    
+
     echo "All processes completed successfully."
 }
 

scripts/hyperconverged-lab.sh

@@ -8,16 +8,26 @@ RUN_EXTRAS=0
 INCLUDE_LIST=()
 EXCLUDE_LIST=()
 
+# yq installation constants
+YQ_VERSION="v4.2.0"
+YQ_BINARY="yq_linux_amd64"
+
 function installYq() {
-    export VERSION=v4.2.0
-    export BINARY=yq_linux_amd64
-    wget https://github.com/mikefarah/yq/releases/download/${VERSION}/${BINARY}.tar.gz -q -O - | tar xz && sudo mv ${BINARY} /usr/local/bin/yq
+    if wget https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/${YQ_BINARY}.tar.gz -O - | tar xz && sudo mv ${YQ_BINARY} /usr/local/bin/yq; then
+        echo "Successfully installed yq version ${YQ_VERSION}"
+        return 0
+    else
+        echo "Failed to install yq"
+        return 1
+    fi
 }
 
 # Install yq locally if needed...
 if ! yq --version 2> /dev/null; then
   echo "yq is not installed. Attempting to install yq"
-  installYq
+  if ! installYq; then
+    echo "[WARNING] Failed to install yq locally"
+  fi
 fi
 
 
@@ -428,6 +438,19 @@ if [ ! -d "/etc/genestack" ]; then
   sudo chown \${USER}:\${USER} -R /etc/genestack
 fi
 
+# Install yq on the remote host if not already present
+if ! command -v yq &> /dev/null; then
+  echo "Installing yq on remote host..."
+  if wget https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/${YQ_BINARY}.tar.gz -O - | tar xz && sudo mv ${YQ_BINARY} /usr/local/bin/yq; then
+    echo "Successfully installed yq version ${YQ_VERSION} on remote host"
+  else
+    echo "Failed to install yq on remote host"
+    exit 1
+  fi
+else
+  echo "yq already available on remote host: \$(yq --version)"
+fi
+
 # We need to clobber the sample or else we get a bogus LB vip
 cat > /etc/genestack/manifests/metallb/metallb-openstack-service-lb.yml <<EOF
 ---