Skip to content

Commit a9fe2a3

Browse files
committed
attempt to reduce flakiness of test/integration/instrumentation_test.rb
1 parent 0e633ff commit a9fe2a3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/integration/instrumentation_test.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -309,14 +309,14 @@ class InstrumentationTest < ActiveSupport::TestCase
309309

310310
events = subscribed("enqueue_recurring_task.solid_queue") do
311311
scheduler.start
312-
wait_while_with_timeout(1.1.second) { SolidQueue::RecurringExecution.none? }
312+
wait_while_with_timeout(1.9.second) { SolidQueue::RecurringExecution.none? || SolidQueue::Job.none? }
313313
scheduler.stop
314314
end
315315

316316
assert events.size >= 1
317-
event = events.last
317+
event = events.find { |e| e.last[:active_job_id] == SolidQueue::Job.last.active_job_id }
318318

319-
assert_event event, "enqueue_recurring_task", task: "example_task", active_job_id: SolidQueue::Job.last.active_job_id
319+
assert_event event, "enqueue_recurring_task", task: "example_task"
320320
assert event.last[:at].present?
321321
assert_nil event.last[:other_adapter]
322322
end
@@ -327,7 +327,7 @@ class InstrumentationTest < ActiveSupport::TestCase
327327

328328
events = subscribed("enqueue_recurring_task.solid_queue") do
329329
schedulers.each(&:start)
330-
sleep 1.01
330+
wait_while_with_timeout(1.9.second) { SolidQueue::RecurringExecution.count <= 2 }
331331
schedulers.each(&:stop)
332332
end
333333

0 commit comments

Comments
 (0)