Update unit tests

Author: rastating

lib/wpxf/wordpress/plugin.rb

@@ -24,7 +24,7 @@ def upload_payload_as_plugin(name, payload_name, cookie)
     res&.code == 200 && res.body !~ /plugin installation failed/i
   end
 
-  # Create and upload the payload without packaging it in a ZIP file.
+  # Upload the payload via the plugin form without packaging it in a ZIP file.
   # @param payload_name [String] the name the payload should use on the server.
   # @param cookie [String] a valid admin session cookie.
   # @return [Boolean] true on success, false on error.

spec/lib/wpxf/wordpress/plugin_spec.rb

@@ -20,12 +20,17 @@
     subject
   end
 
+  let(:post_res) { Wpxf::Net::HttpResponse.new(nil) }
+
   before :each do
     res = Wpxf::Net::HttpResponse.new(nil)
     res.body = body
     res.code = code
 
     allow(subject).to receive(:execute_get_request).and_return(res)
+    allow(subject).to receive(:upload_payload_using_plugin_form).and_call_original
+    allow(subject).to receive(:execute_post_request).and_return(post_res)
+    allow(subject).to receive(:emit_error)
   end
 
   describe '#fetch_plugin_upload_nonce' do
@@ -44,64 +49,145 @@
       expect(script).to match(/\*\sPlugin\sName:\stest/)
       expect(script).to match(/\*\sVersion:\s[0-9]\.[0-9]\.[0-9]{2}/)
       expect(script).to match(/\*\sAuthor:\s[a-zA-Z]{10}/)
-      expect(script).to match(/\*\sAuthor\sURI:\shttp:\/\/[a-zA-Z]{10}\.com/)
+      expect(script).to match(%r{\*\sAuthor\sURI:\shttp://[a-zA-Z]{10}\.com})
     end
   end
 
-  describe '#wordpress_upload_plugin' do
-    it 'returns false if an upload nonce cannot be retrieved' do
-      allow(subject).to receive(:fetch_plugin_upload_nonce).and_return nil
-      res = subject.upload_payload_as_plugin('test', 'test', 'cookie')
-      expect(res).to be false
+  describe '#upload_payload_as_plugin' do
+    context 'if an upload nonce cannot be retrieved' do
+      it 'should return false' do
+        allow(subject).to receive(:fetch_plugin_upload_nonce).and_return nil
+        res = subject.upload_payload_as_plugin('test', 'test', 'cookie')
+        expect(res).to be false
+      end
+    end
+
+    context 'if an upload is successful' do
+      it 'should return true ' do
+        allow(subject).to receive(:fetch_plugin_upload_nonce).and_return 'a'
+        allow(subject).to receive(:execute_post_request) do |opts|
+          expect(opts[:url]).to eq subject.wordpress_url_admin_update
+          expect(opts[:params]).to eq('action' => 'upload-plugin')
+          expect(opts[:cookie]).to eq 'cookie'
+          expect(opts[:body]).to include(
+            '_wpnonce',
+            '_wp_http_referer',
+            'pluginzip',
+            'install-plugin-submit'
+          )
+
+          res = Wpxf::Net::HttpResponse.new(nil)
+          res.code = 200
+          res
+        end
+
+        res = subject.upload_payload_as_plugin('test', 'test', 'cookie')
+        expect(res).to be true
+      end
     end
 
-    it 'returns true if an upload is successful' do
-      allow(subject).to receive(:fetch_plugin_upload_nonce).and_return 'a'
-      allow(subject).to receive(:execute_post_request) do |opts|
-        expect(opts[:url]).to eq subject.wordpress_url_admin_update
-        expect(opts[:params]).to eq('action' => 'upload-plugin')
-        expect(opts[:cookie]).to eq 'cookie'
-        expect(opts[:body]).to include(
-          '_wpnonce',
-          '_wp_http_referer',
-          'pluginzip',
-          'install-plugin-submit'
-        )
-
-        res = Wpxf::Net::HttpResponse.new(nil)
-        res.code = 200
-        res
+    context 'if the response code is not 200' do
+      it 'should return false' do
+        allow(subject).to receive(:fetch_plugin_upload_nonce).and_return 'a'
+        post_res.code = 404
+        res = subject.upload_payload_as_plugin('test', 'test', 'cookie')
+        expect(res).to be false
       end
+    end
+  end
 
-      res = subject.upload_payload_as_plugin('test', 'test', 'cookie')
-      expect(res).to be true
+  describe '#upload_payload_using_plugin_form' do
+    context 'if an upload nonce cannot be retrieved' do
+      it 'should return false' do
+        allow(subject).to receive(:fetch_plugin_upload_nonce).and_return nil
+        res = subject.upload_payload_using_plugin_form('test', 'cookie')
+        expect(res).to be false
+      end
     end
 
-    it 'returns false if the response code is not 200' do
-      allow(subject).to receive(:fetch_plugin_upload_nonce).and_return 'a'
-      allow(subject).to receive(:execute_post_request) do
-        res = Wpxf::Net::HttpResponse.new(nil)
-        res.code = 404
-        res
+    context 'if an upload is successful' do
+      it 'should return true ' do
+        allow(subject).to receive(:fetch_plugin_upload_nonce).and_return 'a'
+        allow(subject).to receive(:execute_post_request) do |opts|
+          expect(opts[:url]).to eq subject.wordpress_url_admin_update
+          expect(opts[:params]).to eq('action' => 'upload-plugin')
+          expect(opts[:cookie]).to eq 'cookie'
+          expect(opts[:body]).to include(
+            '_wpnonce',
+            '_wp_http_referer',
+            'pluginzip',
+            'install-plugin-submit'
+          )
+
+          res = Wpxf::Net::HttpResponse.new(nil)
+          res.code = 200
+          res
+        end
+
+        res = subject.upload_payload_using_plugin_form('test', 'cookie')
+        expect(res).to be true
       end
+    end
 
-      res = subject.upload_payload_as_plugin('test', 'test', 'cookie')
-      expect(res).to be false
+    context 'if the response code is not 200' do
+      it 'should return false' do
+        allow(subject).to receive(:fetch_plugin_upload_nonce).and_return 'a'
+        post_res.code = 404
+        res = subject.upload_payload_using_plugin_form('test', 'cookie')
+        expect(res).to be false
+      end
     end
   end
 
   describe '#upload_payload_as_plugin_and_execute' do
     context 'when the plugin fails to upload' do
-      it 'returns nil' do
-        res = subject.upload_payload_as_plugin_and_execute('', '', '')
-        expect(res).to be_nil
+      it 'should attempt to upload the unpackaged payload' do
+        subject.upload_payload_as_plugin_and_execute('plugin_name', 'payload_name', 'cookie')
+        expect(subject).to have_received(:upload_payload_using_plugin_form)
+          .with('payload_name', 'cookie')
+          .exactly(1).times
+      end
+
+      context 'if both upload attempts fail' do
+        it 'should return nil' do
+          res = subject.upload_payload_as_plugin_and_execute('', '', '')
+          expect(res).to be_nil
+        end
+
+        it 'should emit an error' do
+          subject.upload_payload_as_plugin_and_execute('', '', '')
+          expect(subject).to have_received(:emit_error)
+            .with('Failed to upload the payload')
+            .exactly(1).times
+        end
+      end
+    end
+
+    context 'if the payload was not packaged as a plugin' do
+      it 'should attempt to execute it from the uploads directory' do
+        expected_url = "http://127.0.0.1/wp/wp-content/uploads/#{Time.now.strftime('%Y')}/#{Time.now.strftime('%m')}/test.php"
+        allow(subject).to receive(:upload_payload_using_plugin_form).and_return(true)
+        subject.upload_payload_as_plugin_and_execute('test', 'test', 'cookie')
+        expect(subject).to have_received(:execute_get_request)
+          .with(url: expected_url)
+      end
+    end
+
+    context 'if the payload was packaged as a plugin' do
+      it 'should attempt to execute it from the plugins directory' do
+        expected_url = 'http://127.0.0.1/wp/wp-content/plugins/plugin_name/payload_name.php'
+        allow(subject).to receive(:upload_payload_as_plugin).and_return(true)
+        subject.upload_payload_as_plugin_and_execute('plugin_name', 'payload_name', 'cookie')
+        expect(subject).to have_received(:execute_get_request)
+          .with(url: expected_url)
       end
     end
 
     context 'when the execution returns status 200' do
       let(:code) { 200 }
       let(:body) { 'res content' }
-      it 'emits the response content' do
+
+      it 'should emit the response content' do
         allow(subject).to receive(:upload_payload_as_plugin).and_return true
 
         emitted_content = false
@@ -115,7 +201,7 @@
     end
 
     context 'when the payload is executed' do
-      it 'returns the HttpResponse of the payload request' do
+      it 'should return the HttpResponse of the payload request' do
         allow(subject).to receive(:upload_payload_as_plugin).and_return true
         res = subject.upload_payload_as_plugin_and_execute('', '', '')
         expect(res).to be_kind_of Wpxf::Net::HttpResponse