chore: upgrade react native in example (#948)

* chore: upgrade react native in example

* chore: memory

* chore: update detox

* chore: update tests

* chore: update xcode

* chore: undo android signing

Author: vonovak

.circleci/config.yml

@@ -24,17 +24,18 @@ jobs:
       - run:
           command: yarn lint
           name: Run ESLint
-      - run:
-          command: yarn flow
-          name: Flow
+#      we should just use TS
+#      - run:
+#          command: yarn flow
+#          name: Flow
       - run:
           command: yarn test
           name: Jest
 
   new_arch_ios_build_only:
     executor:
       name: rn/macos
-      xcode_version: '15.3.0'
+      xcode_version: '16.2.0'
       resource_class: macos.m1.medium.gen1
     steps:
       - checkout
@@ -51,7 +52,7 @@ jobs:
   e2e_release_ios:
     executor:
       name: rn/macos
-      xcode_version: '15.3.0'
+      xcode_version: '16.2.0'
       resource_class: macos.m1.medium.gen1
     steps:
       - checkout
@@ -72,7 +73,7 @@ jobs:
       #      - rn/pod_install:
       #          pod_install_directory: 'example/ios'
       - run:
-          command: (cd example && npx pod-install)
+          command: (cd example && RCT_NEW_ARCH_ENABLED=0 npx pod-install)
           name: pod install
       - run:
           command: yarn detox:ios:build:release
@@ -88,6 +89,8 @@ jobs:
       name: android/android-machine
       resource-class: large
       tag: default
+    environment:
+      GRADLE_OPTS: '-Dorg.gradle.jvmargs="-Xmx4g -XX:+HeapDumpOnOutOfMemoryError" -Dorg.gradle.daemon=false'
     steps:
       - checkout
       - android/change-java-version:
@@ -121,6 +124,9 @@ jobs:
       - run:
           command: yarn bundle:android
           name: bundle js
+      - run:
+          command: yarn generateManifest
+          name: generateManifest
       - run:
           command: ORG_GRADLE_PROJECT_newArchEnabled=false yarn detox:android:build:release
           name: build app for e2e tests
@@ -135,6 +141,8 @@ jobs:
       name: android/android-machine
       resource-class: large
       tag: default
+    environment:
+      GRADLE_OPTS: '-Dorg.gradle.jvmargs="-Xmx4g -XX:+HeapDumpOnOutOfMemoryError" -Dorg.gradle.daemon=false'
     steps:
       - checkout
       - android/change-java-version:
@@ -164,6 +172,9 @@ jobs:
       - run:
           command: yarn bundle:android
           name: bundle js
+      - run:
+          command: yarn generateManifest
+          name: generateManifest
       - run:
           command: ORG_GRADLE_PROJECT_newArchEnabled=true yarn detox:android:build:release
           name: build app for e2e tests

example/App.js

@@ -444,7 +444,9 @@ export const App = () => {
                 minimumDate={minimumDate}
                 value={date}
                 mode={mode}
+                // for consistent display
                 is24Hour
+                locale="en-US"
                 display={display}
                 onChange={onChange}
                 textColor={textColor || undefined}

example/android/build.gradle

@@ -40,19 +40,24 @@ allprojects {
         maven {
              // All of Detox' artifacts are provided via the npm module
              url "$rootDir/../../node_modules/detox/Detox-android"
-         }
+        }
         mavenCentral()
         google()
     }
+    // https://github.com/microsoft/react-native-test-app/wiki/Platform-Specifics:-Android#detox
     afterEvaluate { project ->
         def androidExtension = project.extensions.findByName('android')
         if (androidExtension != null && project.name == 'app') {
             androidExtension.defaultConfig {
                 ndk {
                     abiFilters 'arm64-v8a', 'x86', 'x86_64'
                 }
+                // this along with `androidTestImplementation`s fixes
+                // Opening an oat file without a class loader. Are you using the deprecated DexFile APIs?
+                testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
             }
 
+            // needed for release signing
             androidExtension.signingConfigs {
                 test {
                     keyAlias "androiddebugkey"
@@ -65,11 +70,14 @@ allprojects {
             androidExtension.buildTypes.debug.signingConfig = androidExtension.signingConfigs.test
             androidExtension.buildTypes.release.signingConfig = androidExtension.signingConfigs.test
             androidExtension.testBuildType = System.getProperty('testBuildType', 'debug')
+            // end needed for release signing
 
             androidExtension.sourceSets.androidTest.java.srcDirs += "$rootDir/app/src/androidTest/java"
 
             project.dependencies {
                 androidTestImplementation('com.wix:detox:+')
+                androidTestImplementation 'androidx.test:runner:1.5.2'
+                androidTestImplementation 'androidx.test:rules:1.5.2'
             }
         }
     }

example/android/gradle.properties

@@ -25,7 +25,7 @@ org.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryEr
 # https://developer.android.com/topic/libraries/support-library/androidx-rn
 android.useAndroidX=true
 # Automatically convert third-party libraries to use AndroidX
-android.enableJetifier=true
+android.enableJetifier=false
 # Jetifier randomly fails on these libraries
 android.jetifier.ignorelist=hermes-android
 
@@ -40,8 +40,8 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
 # to write custom TurboModules/Fabric components OR use libraries that
 # are providing them.
 # Note that this is incompatible with web debugging.
-#newArchEnabled=true
-#bridgelessEnabled=true
+newArchEnabled=true
+bridgelessEnabled=true
 
 # Uncomment the line below to build React Native from source.
 #react.buildFromSource=true

example/android/gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-all.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME

example/ios/Podfile

@@ -6,4 +6,4 @@ require "#{ws_dir}/node_modules/react-native-test-app/test_app.rb"
 
 workspace 'date-time-picker-example.xcworkspace'
 
-use_test_app!
+use_test_app! :hermes_enabled => true, :fabric_enabled => true, :bridgeless_enabled => true