From 564bdafc2ef4e36040af577c430fee2bf107cfa4 Mon Sep 17 00:00:00 2001
From: Cees-Jan Kiewiet <ceesjank@gmail.com>
Date: Tue, 21 Jan 2025 07:36:38 +0100
Subject: [PATCH] [3.0] Strip FQDN period from the end of the domain

As brought up in #229 we're already treating all domains as absolute,
so adding direct support for it is a small bug fix. That said, fully
support for search domains requires a different handling of this and
will be done in a different PR.
---
 src/Resolver/Resolver.php        |  1 +
 tests/FunctionalResolverTest.php | 11 +++++++++++
 2 files changed, 12 insertions(+)

diff --git a/src/Resolver/Resolver.php b/src/Resolver/Resolver.php
index 6108b3da..dc721582 100644
--- a/src/Resolver/Resolver.php
+++ b/src/Resolver/Resolver.php
@@ -28,6 +28,7 @@ public function resolve($domain)
 
     public function resolveAll($domain, $type)
     {
+        $domain = trim($domain, '.');
         $query = new Query($domain, $type, Message::CLASS_IN);
 
         return $this->executor->query(
diff --git a/tests/FunctionalResolverTest.php b/tests/FunctionalResolverTest.php
index 25900cc0..35781962 100644
--- a/tests/FunctionalResolverTest.php
+++ b/tests/FunctionalResolverTest.php
@@ -48,6 +48,17 @@ public function testResolveGoogleResolves()
         Loop::run();
     }
 
+    /**
+     * @group internet
+     */
+    public function testResolveGoogleFQDNResolves()
+    {
+        $promise = $this->resolver->resolve('google.com.');
+        $promise->then($this->expectCallableOnce(), $this->expectCallableNever());
+
+        Loop::run();
+    }
+
     /**
      * @group internet
      */