Merge pull request #178 from clue-labs/types

WyriHaximus · web-flow · commit cf107f5963db · 2024-05-19T21:40:04.000+02:00
Add native types to public API
diff --git a/README.md b/README.md
@@ -324,7 +324,7 @@ See also `pause()`.
 
 #### pipe()
 
-The `pipe(WritableStreamInterface $dest, array $options = [])` method can be used to
+The `pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface` method can be used to
 pipe all the data from this readable source into the given writable destination.
 
 Automatically sends all incoming data to the destination.
diff --git a/src/CompositeStream.php b/src/CompositeStream.php
@@ -27,17 +27,17 @@ public function __construct(ReadableStreamInterface $readable, WritableStreamInt
         $this->writable->on('close', [$this, 'close']);
     }
 
-    public function isReadable()
+    public function isReadable(): bool
     {
         return $this->readable->isReadable();
     }
 
-    public function pause()
+    public function pause(): void
     {
         $this->readable->pause();
     }
 
-    public function resume()
+    public function resume(): void
     {
         if (!$this->writable->isWritable()) {
             return;
@@ -46,28 +46,28 @@ public function resume()
         $this->readable->resume();
     }
 
-    public function pipe(WritableStreamInterface $dest, array $options = [])
+    public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface
     {
         return Util::pipe($this, $dest, $options);
     }
 
-    public function isWritable()
+    public function isWritable(): bool
     {
         return $this->writable->isWritable();
     }
 
-    public function write($data)
+    public function write($data): bool
     {
         return $this->writable->write($data);
     }
 
-    public function end($data = null)
+    public function end($data = null): void
     {
         $this->readable->pause();
         $this->writable->end($data);
     }
 
-    public function close()
+    public function close(): void
     {
         if ($this->closed) {
             return;
diff --git a/src/DuplexResourceStream.php b/src/DuplexResourceStream.php
@@ -44,7 +44,7 @@ final class DuplexResourceStream extends EventEmitter implements DuplexStreamInt
      * @param ?int $readChunkSize
      * @param ?WritableStreamInterface $buffer
      */
-    public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize = null, ?WritableStreamInterface $buffer = null)
+    public function __construct($stream, ?LoopInterface $loop = null, ?int $readChunkSize = null, ?WritableStreamInterface $buffer = null)
     {
         if (!\is_resource($stream) || \get_resource_type($stream) !== "stream") {
              throw new InvalidArgumentException('First parameter must be a valid stream resource');
@@ -75,7 +75,7 @@ public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize
 
         $this->stream = $stream;
         $this->loop = $loop ?: Loop::get();
-        $this->bufferSize = ($readChunkSize === null) ? 65536 : (int)$readChunkSize;
+        $this->bufferSize = $readChunkSize ?? 65536;
         $this->buffer = $buffer;
 
         $this->buffer->on('error', function ($error) {
@@ -91,33 +91,33 @@ public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize
         $this->resume();
     }
 
-    public function isReadable()
+    public function isReadable(): bool
     {
         return $this->readable;
     }
 
-    public function isWritable()
+    public function isWritable(): bool
     {
         return $this->writable;
     }
 
-    public function pause()
+    public function pause(): void
     {
         if ($this->listening) {
             $this->loop->removeReadStream($this->stream);
             $this->listening = false;
         }
     }
 
-    public function resume()
+    public function resume(): void
     {
         if (!$this->listening && $this->readable) {
             $this->loop->addReadStream($this->stream, [$this, 'handleData']);
             $this->listening = true;
         }
     }
 
-    public function write($data)
+    public function write($data): bool
     {
         if (!$this->writable) {
             return false;
@@ -126,7 +126,7 @@ public function write($data)
         return $this->buffer->write($data);
     }
 
-    public function close()
+    public function close(): void
     {
         if (!$this->writable && !$this->closing) {
             return;
@@ -147,7 +147,7 @@ public function close()
         }
     }
 
-    public function end($data = null)
+    public function end($data = null): void
     {
         if (!$this->writable) {
             return;
@@ -162,7 +162,7 @@ public function end($data = null)
         $this->buffer->end($data);
     }
 
-    public function pipe(WritableStreamInterface $dest, array $options = [])
+    public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface
     {
         return Util::pipe($this, $dest, $options);
     }
diff --git a/src/ReadableResourceStream.php b/src/ReadableResourceStream.php
@@ -45,7 +45,7 @@ final class ReadableResourceStream extends EventEmitter implements ReadableStrea
      * @param ?LoopInterface $loop
      * @param ?int $readChunkSize
      */
-    public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize = null)
+    public function __construct($stream, ?LoopInterface $loop = null, ?int $readChunkSize = null)
     {
         if (!\is_resource($stream) || \get_resource_type($stream) !== "stream") {
              throw new InvalidArgumentException('First parameter must be a valid stream resource');
@@ -72,38 +72,38 @@ public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize
 
         $this->stream = $stream;
         $this->loop = $loop ?: Loop::get();
-        $this->bufferSize = ($readChunkSize === null) ? 65536 : (int)$readChunkSize;
+        $this->bufferSize = $readChunkSize ?? 65536;
 
         $this->resume();
     }
 
-    public function isReadable()
+    public function isReadable(): bool
     {
         return !$this->closed;
     }
 
-    public function pause()
+    public function pause(): void
     {
         if ($this->listening) {
             $this->loop->removeReadStream($this->stream);
             $this->listening = false;
         }
     }
 
-    public function resume()
+    public function resume(): void
     {
         if (!$this->listening && !$this->closed) {
             $this->loop->addReadStream($this->stream, [$this, 'handleData']);
             $this->listening = true;
         }
     }
 
-    public function pipe(WritableStreamInterface $dest, array $options = [])
+    public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface
     {
         return Util::pipe($this, $dest, $options);
     }
 
-    public function close()
+    public function close(): void
     {
         if ($this->closed) {
             return;
diff --git a/src/ReadableStreamInterface.php b/src/ReadableStreamInterface.php
@@ -194,7 +194,7 @@ interface ReadableStreamInterface extends EventEmitterInterface
      *
      * @return bool
      */
-    public function isReadable();
+    public function isReadable(): bool;
 
     /**
      * Pauses reading incoming data events.
@@ -226,7 +226,7 @@ public function isReadable();
      * @see self::resume()
      * @return void
      */
-    public function pause();
+    public function pause(): void;
 
     /**
      * Resumes reading incoming data events.
@@ -247,7 +247,7 @@ public function pause();
      * @see self::pause()
      * @return void
      */
-    public function resume();
+    public function resume(): void;
 
     /**
      * Pipes all the data from this readable source into the given writable destination.
@@ -322,7 +322,7 @@ public function resume();
      * @param array $options
      * @return WritableStreamInterface $dest stream as-is
      */
-    public function pipe(WritableStreamInterface $dest, array $options = []);
+    public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface;
 
     /**
      * Closes the stream (forcefully).
@@ -358,5 +358,5 @@ public function pipe(WritableStreamInterface $dest, array $options = []);
      * @return void
      * @see WritableStreamInterface::close()
      */
-    public function close();
+    public function close(): void;
 }
diff --git a/src/ThroughStream.php b/src/ThroughStream.php
@@ -82,22 +82,18 @@ final class ThroughStream extends EventEmitter implements DuplexStreamInterface
     private $drain = false;
     private $callback;
 
-    public function __construct($callback = null)
+    public function __construct(?callable $callback = null)
     {
-        if ($callback !== null && !\is_callable($callback)) {
-            throw new InvalidArgumentException('Invalid transformation callback given');
-        }
-
         $this->callback = $callback;
     }
 
-    public function pause()
+    public function pause(): void
     {
         // only allow pause if still readable, false otherwise
         $this->paused = $this->readable;
     }
 
-    public function resume()
+    public function resume(): void
     {
         $this->paused = false;
 
@@ -108,22 +104,22 @@ public function resume()
         }
     }
 
-    public function pipe(WritableStreamInterface $dest, array $options = [])
+    public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface
     {
         return Util::pipe($this, $dest, $options);
     }
 
-    public function isReadable()
+    public function isReadable(): bool
     {
         return $this->readable;
     }
 
-    public function isWritable()
+    public function isWritable(): bool
     {
         return $this->writable;
     }
 
-    public function write($data)
+    public function write($data): bool
     {
         if (!$this->writable) {
             return false;
@@ -151,7 +147,7 @@ public function write($data)
         return $this->writable && !$this->paused;
     }
 
-    public function end($data = null)
+    public function end($data = null): void
     {
         if (!$this->writable) {
             return;
@@ -175,7 +171,7 @@ public function end($data = null)
         $this->close();
     }
 
-    public function close()
+    public function close(): void
     {
         if ($this->closed) {
             return;
diff --git a/src/Util.php b/src/Util.php
@@ -13,7 +13,7 @@ final class Util
      * @return WritableStreamInterface $dest stream as-is
      * @see ReadableStreamInterface::pipe() for more details
      */
-    public static function pipe(ReadableStreamInterface $source, WritableStreamInterface $dest, array $options = [])
+    public static function pipe(ReadableStreamInterface $source, WritableStreamInterface $dest, array $options = []): WritableStreamInterface
     {
         // source not readable => NO-OP
         if (!$source->isReadable()) {
@@ -64,7 +64,13 @@ public static function pipe(ReadableStreamInterface $source, WritableStreamInter
         return $dest;
     }
 
-    public static function forwardEvents($source, $target, array $events)
+    /**
+     * @param ReadableStreamInterface|WritableStreamInterface $source
+     * @param ReadableStreamInterface|WritableStreamInterface $target
+     * @param string[] $events
+     * @return void
+     */
+    public static function forwardEvents($source, $target, array $events): void
     {
         foreach ($events as $event) {
             $source->on($event, function () use ($event, $target) {
diff --git a/src/WritableResourceStream.php b/src/WritableResourceStream.php
@@ -34,7 +34,7 @@ final class WritableResourceStream extends EventEmitter implements WritableStrea
      * @param ?int $writeBufferSoftLimit
      * @param ?int $writeChunkSize
      */
-    public function __construct($stream, ?LoopInterface $loop = null, $writeBufferSoftLimit = null, $writeChunkSize = null)
+    public function __construct($stream, ?LoopInterface $loop = null, ?int $writeBufferSoftLimit = null, ?int $writeChunkSize = null)
     {
         if (!\is_resource($stream) || \get_resource_type($stream) !== "stream") {
             throw new \InvalidArgumentException('First parameter must be a valid stream resource');
@@ -54,16 +54,16 @@ public function __construct($stream, ?LoopInterface $loop = null, $writeBufferSo
 
         $this->stream = $stream;
         $this->loop = $loop ?: Loop::get();
-        $this->softLimit = ($writeBufferSoftLimit === null) ? 65536 : (int)$writeBufferSoftLimit;
-        $this->writeChunkSize = ($writeChunkSize === null) ? -1 : (int)$writeChunkSize;
+        $this->softLimit = $writeBufferSoftLimit ?? 65536;
+        $this->writeChunkSize = $writeChunkSize ?? -1;
     }
 
-    public function isWritable()
+    public function isWritable(): bool
     {
         return $this->writable;
     }
 
-    public function write($data)
+    public function write($data): bool
     {
         if (!$this->writable) {
             return false;
@@ -80,7 +80,7 @@ public function write($data)
         return !isset($this->data[$this->softLimit - 1]);
     }
 
-    public function end($data = null)
+    public function end($data = null): void
     {
         if (null !== $data) {
             $this->write($data);
@@ -95,7 +95,7 @@ public function end($data = null)
         }
     }
 
-    public function close()
+    public function close(): void
     {
         if ($this->closed) {
             return;
diff --git a/src/WritableStreamInterface.php b/src/WritableStreamInterface.php
diff --git a/tests/Stub/ReadableStreamStub.php b/tests/Stub/ReadableStreamStub.php
diff --git a/tests/ThroughStreamTest.php b/tests/ThroughStreamTest.php

Original file line number	Diff line number	Diff line change
`@@ -27,17 +27,17 @@ public function __construct(ReadableStreamInterface $readable, WritableStreamInt`
`27`	`27`	`$this->writable->on('close', [$this, 'close']);`
`28`	`28`	`}`
`29`	`29`
`30`		`- public function isReadable()`
	`30`	`+ public function isReadable(): bool`
`31`	`31`	`{`
`32`	`32`	`return $this->readable->isReadable();`
`33`	`33`	`}`
`34`	`34`
`35`		`- public function pause()`
	`35`	`+ public function pause(): void`
`36`	`36`	`{`
`37`	`37`	`$this->readable->pause();`
`38`	`38`	`}`
`39`	`39`
`40`		`- public function resume()`
	`40`	`+ public function resume(): void`
`41`	`41`	`{`
`42`	`42`	`if (!$this->writable->isWritable()) {`
`43`	`43`	`return;`
`@@ -46,28 +46,28 @@ public function resume()`
`46`	`46`	`$this->readable->resume();`
`47`	`47`	`}`
`48`	`48`
`49`		`- public function pipe(WritableStreamInterface $dest, array $options = [])`
	`49`	`+ public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface`
`50`	`50`	`{`
`51`	`51`	`return Util::pipe($this, $dest, $options);`
`52`	`52`	`}`
`53`	`53`
`54`		`- public function isWritable()`
	`54`	`+ public function isWritable(): bool`
`55`	`55`	`{`
`56`	`56`	`return $this->writable->isWritable();`
`57`	`57`	`}`
`58`	`58`
`59`		`- public function write($data)`
	`59`	`+ public function write($data): bool`
`60`	`60`	`{`
`61`	`61`	`return $this->writable->write($data);`
`62`	`62`	`}`
`63`	`63`
`64`		`- public function end($data = null)`
	`64`	`+ public function end($data = null): void`
`65`	`65`	`{`
`66`	`66`	`$this->readable->pause();`
`67`	`67`	`$this->writable->end($data);`
`68`	`68`	`}`
`69`	`69`
`70`		`- public function close()`
	`70`	`+ public function close(): void`
`71`	`71`	`{`
`72`	`72`	`if ($this->closed) {`
`73`	`73`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ final class DuplexResourceStream extends EventEmitter implements DuplexStreamInt`
`44`	`44`	`* @param ?int $readChunkSize`
`45`	`45`	`* @param ?WritableStreamInterface $buffer`
`46`	`46`	`*/`
`47`		`- public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize = null, ?WritableStreamInterface $buffer = null)`
	`47`	`+ public function __construct($stream, ?LoopInterface $loop = null, ?int $readChunkSize = null, ?WritableStreamInterface $buffer = null)`
`48`	`48`	`{`
`49`	`49`	`if (!\is_resource($stream) \|\| \get_resource_type($stream) !== "stream") {`
`50`	`50`	`throw new InvalidArgumentException('First parameter must be a valid stream resource');`
`@@ -75,7 +75,7 @@ public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize`
`75`	`75`
`76`	`76`	`$this->stream = $stream;`
`77`	`77`	`$this->loop = $loop ?: Loop::get();`
`78`		`- $this->bufferSize = ($readChunkSize === null) ? 65536 : (int)$readChunkSize;`
	`78`	`+ $this->bufferSize = $readChunkSize ?? 65536;`
`79`	`79`	`$this->buffer = $buffer;`
`80`	`80`
`81`	`81`	`$this->buffer->on('error', function ($error) {`
`@@ -91,33 +91,33 @@ public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize`
`91`	`91`	`$this->resume();`
`92`	`92`	`}`
`93`	`93`
`94`		`- public function isReadable()`
	`94`	`+ public function isReadable(): bool`
`95`	`95`	`{`
`96`	`96`	`return $this->readable;`
`97`	`97`	`}`
`98`	`98`
`99`		`- public function isWritable()`
	`99`	`+ public function isWritable(): bool`
`100`	`100`	`{`
`101`	`101`	`return $this->writable;`
`102`	`102`	`}`
`103`	`103`
`104`		`- public function pause()`
	`104`	`+ public function pause(): void`
`105`	`105`	`{`
`106`	`106`	`if ($this->listening) {`
`107`	`107`	`$this->loop->removeReadStream($this->stream);`
`108`	`108`	`$this->listening = false;`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`
`112`		`- public function resume()`
	`112`	`+ public function resume(): void`
`113`	`113`	`{`
`114`	`114`	`if (!$this->listening && $this->readable) {`
`115`	`115`	`$this->loop->addReadStream($this->stream, [$this, 'handleData']);`
`116`	`116`	`$this->listening = true;`
`117`	`117`	`}`
`118`	`118`	`}`
`119`	`119`
`120`		`- public function write($data)`
	`120`	`+ public function write($data): bool`
`121`	`121`	`{`
`122`	`122`	`if (!$this->writable) {`
`123`	`123`	`return false;`
`@@ -126,7 +126,7 @@ public function write($data)`
`126`	`126`	`return $this->buffer->write($data);`
`127`	`127`	`}`
`128`	`128`
`129`		`- public function close()`
	`129`	`+ public function close(): void`
`130`	`130`	`{`
`131`	`131`	`if (!$this->writable && !$this->closing) {`
`132`	`132`	`return;`
`@@ -147,7 +147,7 @@ public function close()`
`147`	`147`	`}`
`148`	`148`	`}`
`149`	`149`
`150`		`- public function end($data = null)`
	`150`	`+ public function end($data = null): void`
`151`	`151`	`{`
`152`	`152`	`if (!$this->writable) {`
`153`	`153`	`return;`
`@@ -162,7 +162,7 @@ public function end($data = null)`
`162`	`162`	`$this->buffer->end($data);`
`163`	`163`	`}`
`164`	`164`
`165`		`- public function pipe(WritableStreamInterface $dest, array $options = [])`
	`165`	`+ public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface`
`166`	`166`	`{`
`167`	`167`	`return Util::pipe($this, $dest, $options);`
`168`	`168`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ final class ReadableResourceStream extends EventEmitter implements ReadableStrea`
`45`	`45`	`* @param ?LoopInterface $loop`
`46`	`46`	`* @param ?int $readChunkSize`
`47`	`47`	`*/`
`48`		`- public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize = null)`
	`48`	`+ public function __construct($stream, ?LoopInterface $loop = null, ?int $readChunkSize = null)`
`49`	`49`	`{`
`50`	`50`	`if (!\is_resource($stream) \|\| \get_resource_type($stream) !== "stream") {`
`51`	`51`	`throw new InvalidArgumentException('First parameter must be a valid stream resource');`
`@@ -72,38 +72,38 @@ public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize`
`72`	`72`
`73`	`73`	`$this->stream = $stream;`
`74`	`74`	`$this->loop = $loop ?: Loop::get();`
`75`		`- $this->bufferSize = ($readChunkSize === null) ? 65536 : (int)$readChunkSize;`
	`75`	`+ $this->bufferSize = $readChunkSize ?? 65536;`
`76`	`76`
`77`	`77`	`$this->resume();`
`78`	`78`	`}`
`79`	`79`
`80`		`- public function isReadable()`
	`80`	`+ public function isReadable(): bool`
`81`	`81`	`{`
`82`	`82`	`return !$this->closed;`
`83`	`83`	`}`
`84`	`84`
`85`		`- public function pause()`
	`85`	`+ public function pause(): void`
`86`	`86`	`{`
`87`	`87`	`if ($this->listening) {`
`88`	`88`	`$this->loop->removeReadStream($this->stream);`
`89`	`89`	`$this->listening = false;`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`
`93`		`- public function resume()`
	`93`	`+ public function resume(): void`
`94`	`94`	`{`
`95`	`95`	`if (!$this->listening && !$this->closed) {`
`96`	`96`	`$this->loop->addReadStream($this->stream, [$this, 'handleData']);`
`97`	`97`	`$this->listening = true;`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`
`101`		`- public function pipe(WritableStreamInterface $dest, array $options = [])`
	`101`	`+ public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface`
`102`	`102`	`{`
`103`	`103`	`return Util::pipe($this, $dest, $options);`
`104`	`104`	`}`
`105`	`105`
`106`		`- public function close()`
	`106`	`+ public function close(): void`
`107`	`107`	`{`
`108`	`108`	`if ($this->closed) {`
`109`	`109`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -82,22 +82,18 @@ final class ThroughStream extends EventEmitter implements DuplexStreamInterface`
`82`	`82`	`private $drain = false;`
`83`	`83`	`private $callback;`
`84`	`84`
`85`		`- public function __construct($callback = null)`
	`85`	`+ public function __construct(?callable $callback = null)`
`86`	`86`	`{`
`87`		`- if ($callback !== null && !\is_callable($callback)) {`
`88`		`- throw new InvalidArgumentException('Invalid transformation callback given');`
`89`		`- }`
`90`		`-`
`91`	`87`	`$this->callback = $callback;`
`92`	`88`	`}`
`93`	`89`
`94`		`- public function pause()`
	`90`	`+ public function pause(): void`
`95`	`91`	`{`
`96`	`92`	`// only allow pause if still readable, false otherwise`
`97`	`93`	`$this->paused = $this->readable;`
`98`	`94`	`}`
`99`	`95`
`100`		`- public function resume()`
	`96`	`+ public function resume(): void`
`101`	`97`	`{`
`102`	`98`	`$this->paused = false;`
`103`	`99`
`@@ -108,22 +104,22 @@ public function resume()`
`108`	`104`	`}`
`109`	`105`	`}`
`110`	`106`
`111`		`- public function pipe(WritableStreamInterface $dest, array $options = [])`
	`107`	`+ public function pipe(WritableStreamInterface $dest, array $options = []): WritableStreamInterface`
`112`	`108`	`{`
`113`	`109`	`return Util::pipe($this, $dest, $options);`
`114`	`110`	`}`
`115`	`111`
`116`		`- public function isReadable()`
	`112`	`+ public function isReadable(): bool`
`117`	`113`	`{`
`118`	`114`	`return $this->readable;`
`119`	`115`	`}`
`120`	`116`
`121`		`- public function isWritable()`
	`117`	`+ public function isWritable(): bool`
`122`	`118`	`{`
`123`	`119`	`return $this->writable;`
`124`	`120`	`}`
`125`	`121`
`126`		`- public function write($data)`
	`122`	`+ public function write($data): bool`
`127`	`123`	`{`
`128`	`124`	`if (!$this->writable) {`
`129`	`125`	`return false;`
`@@ -151,7 +147,7 @@ public function write($data)`
`151`	`147`	`return $this->writable && !$this->paused;`
`152`	`148`	`}`
`153`	`149`
`154`		`- public function end($data = null)`
	`150`	`+ public function end($data = null): void`
`155`	`151`	`{`
`156`	`152`	`if (!$this->writable) {`
`157`	`153`	`return;`
`@@ -175,7 +171,7 @@ public function end($data = null)`
`175`	`171`	`$this->close();`
`176`	`172`	`}`
`177`	`173`
`178`		`- public function close()`
	`174`	`+ public function close(): void`
`179`	`175`	`{`
`180`	`176`	`if ($this->closed) {`
`181`	`177`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ final class WritableResourceStream extends EventEmitter implements WritableStrea`
`34`	`34`	`* @param ?int $writeBufferSoftLimit`
`35`	`35`	`* @param ?int $writeChunkSize`
`36`	`36`	`*/`
`37`		`- public function __construct($stream, ?LoopInterface $loop = null, $writeBufferSoftLimit = null, $writeChunkSize = null)`
	`37`	`+ public function __construct($stream, ?LoopInterface $loop = null, ?int $writeBufferSoftLimit = null, ?int $writeChunkSize = null)`
`38`	`38`	`{`
`39`	`39`	`if (!\is_resource($stream) \|\| \get_resource_type($stream) !== "stream") {`
`40`	`40`	`throw new \InvalidArgumentException('First parameter must be a valid stream resource');`
`@@ -54,16 +54,16 @@ public function __construct($stream, ?LoopInterface $loop = null, $writeBufferSo`
`54`	`54`
`55`	`55`	`$this->stream = $stream;`
`56`	`56`	`$this->loop = $loop ?: Loop::get();`
`57`		`- $this->softLimit = ($writeBufferSoftLimit === null) ? 65536 : (int)$writeBufferSoftLimit;`
`58`		`- $this->writeChunkSize = ($writeChunkSize === null) ? -1 : (int)$writeChunkSize;`
	`57`	`+ $this->softLimit = $writeBufferSoftLimit ?? 65536;`
	`58`	`+ $this->writeChunkSize = $writeChunkSize ?? -1;`
`59`	`59`	`}`
`60`	`60`
`61`		`- public function isWritable()`
	`61`	`+ public function isWritable(): bool`
`62`	`62`	`{`
`63`	`63`	`return $this->writable;`
`64`	`64`	`}`
`65`	`65`
`66`		`- public function write($data)`
	`66`	`+ public function write($data): bool`
`67`	`67`	`{`
`68`	`68`	`if (!$this->writable) {`
`69`	`69`	`return false;`
`@@ -80,7 +80,7 @@ public function write($data)`
`80`	`80`	`return !isset($this->data[$this->softLimit - 1]);`
`81`	`81`	`}`
`82`	`82`
`83`		`- public function end($data = null)`
	`83`	`+ public function end($data = null): void`
`84`	`84`	`{`
`85`	`85`	`if (null !== $data) {`
`86`	`86`	`$this->write($data);`
`@@ -95,7 +95,7 @@ public function end($data = null)`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`
`98`		`- public function close()`
	`98`	`+ public function close(): void`
`99`	`99`	`{`
`100`	`100`	`if ($this->closed) {`
`101`	`101`	`return;`