Skip to content

Update the config steps to cache a True result. #12554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

Update the config steps to cache a True result. #12554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions readthedocs/projects/views/private.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,8 @@ def show_config_step(wizard):
# This is a problem for us because we perform external calls here and add messages to the request.
# Due to that, we are adding this instance variable to prevent this function to run multiple times.
# Maybe related to https://github.com/jazzband/django-formtools/issues/134
if hasattr(wizard, "_show_config_step_executed"):
return False
if hasattr(wizard, "_show_config_step_result"):
return wizard._show_config_step_result

remote_repository_relations = (
remote_repository.remote_repository_relations.filter(
Expand Down Expand Up @@ -341,14 +341,18 @@ def show_config_step(wizard):
"We detected a configuration file in your repository and started your project's first build."
),
)
wizard._show_config_step_executed = True
wizard._show_config_step_result = False
return False
except Exception:
log.warning(
"Failed when hitting GitHub API to check for .readthedocs.yaml file.",
filename=yaml,
)
continue

# Cache the result for consistency
wizard._show_config_step_result = True
return True
return True


Expand Down