Don't log exceptions on instance protection #12568
Open
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
Nov 11, 2025
| log.exception("Failed when trying to set instance protection.") | ||
| # Don't log these as exceptions, | ||
| # since there isn't much we can do about it here. | ||
| log.info("Failed when trying to set instance protection.") |
Contributor
There was a problem hiding this comment.
It's probably worth catching ValidationError/ClientError specifically and not logging that as an exception (or at all), leaving the general exception catch logged as an exception in case there is something we aren't expecting here. We won't pay much attention to this if it's just in logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.