Skip to content

Commit 0bf9fcb

Browse files
Merge pull request #7 from realFlowControl/php-8.4
PHP 8.4 checks in CI
2 parents 3043b38 + 698ec9a commit 0bf9fcb

File tree

5 files changed

+31
-76
lines changed

5 files changed

+31
-76
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
on:
2-
- pull_request
3-
- push
2+
pull_request: null
3+
push:
4+
branches:
5+
- master
46

57
name: CI
68

@@ -12,7 +14,7 @@ jobs:
1214
runs-on: ubuntu-latest
1315
steps:
1416
- name: Checkout
15-
uses: actions/checkout@v2
17+
uses: actions/checkout@v4
1618

1719
- name: Validate composer.json and composer.lock
1820
run: composer validate
@@ -31,7 +33,7 @@ jobs:
3133
run: echo "::set-output name=dir::$(composer config cache-files-dir)"
3234

3335
- name: Cache dependencies
34-
uses: actions/cache@v2
36+
uses: actions/cache@v4
3537
with:
3638
path: ${{ steps.composer-cache.outputs.dir }}
3739
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -47,17 +49,14 @@ jobs:
4749
- name: Static Analyzer (PHPStan)
4850
run: composer test:phpstan
4951

50-
- name: Static Analyzer (Psalm)
51-
run: composer test:psalm
52-
5352
Tests:
5453
strategy:
5554
matrix:
56-
php-versions: ['8.0', '8.1', '8.2', '8.3']
55+
php-versions: ['8.0', '8.1', '8.2', '8.3', '8.4']
5756
runs-on: ubuntu-latest
5857
steps:
5958
- name: Checkout
60-
uses: actions/checkout@v2
59+
uses: actions/checkout@v4
6160

6261
- name: Validate composer.json and composer.lock
6362
run: composer validate
@@ -76,7 +75,7 @@ jobs:
7675
run: echo "::set-output name=dir::$(composer config cache-files-dir)"
7776

7877
- name: Cache dependencies
79-
uses: actions/cache@v2
78+
uses: actions/cache@v4
8079
with:
8180
path: ${{ steps.composer-cache.outputs.dir }}
8281
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}

CHANGELOG.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,25 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [2.2.0] - 2024-11-27
8+
9+
### Added
10+
- Support for PHP 8.4
11+
12+
### Removed
13+
- Psalm
14+
15+
## [2.1.0] - 2023-09-23
16+
17+
# Added
18+
19+
- Support PHP 8.2 (#3, thanks @devnix)
20+
- More specific return type for `Flowcontrol\React\Inotify\InotifyStream::addWatch` (#4, thanks @devnix)
21+
22+
# Fixed
23+
24+
- GitHub Action Badge in `README.md`
25+
726
## [2.0.0] - 2022-01-06
827

928
### Added
@@ -59,6 +78,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
5978
- unit tests
6079
- static code analysis using Pslam and PHPStan
6180

81+
[2.2.0]: https://github.com/flow-control/react-inotify/compare/v2.1.0...v2.2.0
82+
[2.1.0]: https://github.com/flow-control/react-inotify/compare/v2.0.0...v2.1.0
6283
[2.0.0]: https://github.com/flow-control/react-inotify/compare/v1.1.1...v2.0.0
6384
[1.1.1]: https://github.com/flow-control/react-inotify/compare/v1.1.0...v1.1.1
6485
[1.1.0]: https://github.com/flow-control/react-inotify/compare/v1.0.2...v1.1.0

composer.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@
1212
"require-dev": {
1313
"phpunit/phpunit": "^8.5|^9.5",
1414
"phpstan/phpstan": "^1.0.0",
15-
"infection/infection": "<1.0",
16-
"vimeo/psalm": "^5.0"
15+
"infection/infection": "<1.0"
1716
},
1817
"autoload": {
1918
"psr-4": {
@@ -29,7 +28,6 @@
2928
"fix": "./tools/php-cs-fixer.phar fix",
3029
"test:lint": "./tools/php-cs-fixer.phar fix --dry-run",
3130
"test:phpstan": "phpstan analyse --level max examples/ src/",
32-
"test:psalm": "psalm src/ examples/",
3331
"test:unit": [
3432
"@putenv XDEBUG_MODE=coverage",
3533
"phpunit"
@@ -41,7 +39,6 @@
4139
"test": [
4240
"@test:lint",
4341
"@test:phpstan",
44-
"@test:psalm",
4542
"@test:unit",
4643
"@test:mutation"
4744
]

psalm.xml

Lines changed: 0 additions & 58 deletions
This file was deleted.

src/InotifyStream.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@ final class InotifyStream extends EventEmitter
3838
*/
3939
private $watchers = [];
4040

41-
/**
42-
* @psalm-suppress RedundantConditionGivenDocblockType
43-
* @psalm-suppress DocblockTypeContradiction
44-
*/
4541
public function __construct(?LoopInterface $loop = null)
4642
{
4743
$inotify = inotify_init();

0 commit comments

Comments
 (0)