credentials when using secrets_as_variables: (#140)

* credentials when using secrets_as_variables:
- also replace other non valid characters with underscore
- add a default to '$encrypted$' if variable is not set

* typo

Author: rockyhb

roles/filetree_create/templates/controller_credentials.j2

@@ -20,7 +20,7 @@ controller_credentials:
 {%     if show_encrypted is defined and show_encrypted %}
       {{ input.key }}: {{ input.value }}
 {%     elif secrets_as_variables is defined and secrets_as_variables %}
-      {{ input.key }}: {{ input.value | replace("$encrypted$", "\"{{ " + secrets_as_variables_prefix + "_controller_credentials_" + (current_credentials_asset_value.name | replace(' ', '_') | lower) + "_" + (input.key | replace(' ', '_') | lower) + " }}\"") }}
+      {{ input.key }}: {{ input.value | replace("$encrypted$", "\"{{ " + secrets_as_variables_prefix + "_controller_credentials_" + (current_credentials_asset_value.name | lower | regex_replace('[^a-z0-9]','_')) + "_" + (input.key | lower | regex_replace('[^a-z0-9]', '_')) + " | default('$encrypted$') }}\"") }}
 {%     else %}
       {{ input.key }}: {{ input.value | replace("$encrypted$", "\'\'") }}
 {%     endif %}

roles/filetree_create/templates/eda_credentials.j2

@@ -23,7 +23,7 @@ eda_credentials:
 {%     if show_encrypted is defined and show_encrypted %}
       {{ input.key }}: {{ input.value }}
 {%     elif secrets_as_variables is defined and secrets_as_variables %}
-      {{ input.key }}: {{ input.value | replace("$encrypted$", "\"{{ " + secrets_as_variables_prefix + "_eda_credentials_" + (eda_credential.name | replace(' ', '_') | lower) + "_" + (input.key | replace(' ', '_') | lower) + " }}\"") }}
+      {{ input.key }}: {{ input.value | replace("$encrypted$", "\"{{ " + secrets_as_variables_prefix + "_eda_credentials_" + (eda_credential.name | lower | regex_replace('[^a-z0-9]','_')) + "_" + (input.key | lower | regex_replace('[^a-z0-9]','_')) + " | default('$encrypted$') }}\"") }}
 {%     else %}
       {{ input.key }}: {{ input.value | replace("$encrypted$", "\'\'") }}
 {%     endif %}