Switch db value to json

Signed-off-by: Dominika Zemanovicova <[email protected]>

Author: dzemanov

workspaces/scorecard/plugins/scorecard-backend/migrations/20250915113801_init.js

@@ -27,7 +27,7 @@ exports.up = async function up(knex) {
       .notNullable()
       .comment('The entity ref for which this metric value was calculated');
     table
-      .decimal('value', 15, 6)
+      .json('value')
       .nullable()
       .comment('Metric value when calculation succeeds');
     table

workspaces/scorecard/plugins/scorecard-backend/src/database/MetricValuesStore.ts

@@ -14,11 +14,13 @@
  * limitations under the License.
  */
 
+import { MetricValue } from '@red-hat-developer-hub/backstage-plugin-scorecard-common';
+
 export type DbMetricValue = {
   id: number;
   catalog_entity_ref: string;
   metric_id: string;
-  value?: number;
+  value?: MetricValue;
   timestamp: Date;
   error_message?: string;
 };

workspaces/scorecard/plugins/scorecard-backend/src/service/CatalogMetricService.ts

@@ -102,10 +102,6 @@ export class CatalogMetricService {
     return rawResults.map(({ metric_id, value, error_message, timestamp }) => {
       const provider = this.registry.getProvider(metric_id);
       const metric = provider.getMetric();
-      const convertedValue =
-        metric.type === 'boolean' && value !== undefined
-          ? Boolean(value)
-          : value;
 
       let thresholds: ThresholdConfig | undefined;
       let evaluation: string | undefined;
@@ -116,12 +112,12 @@ export class CatalogMetricService {
           provider,
           metric.type,
         );
-        if (convertedValue === undefined) {
+        if (value === undefined) {
           thresholdError =
             'Unable to evaluate thresholds, metric value is missing';
         } else {
           evaluation = this.thresholdEvaluator.getFirstMatchingThreshold(
-            convertedValue,
+            value,
             metric.type,
             thresholds,
           );
@@ -146,7 +142,7 @@ export class CatalogMetricService {
             stringifyError(new Error(`Metric value is 'undefined'`)),
         }),
         result: {
-          value: convertedValue,
+          value,
           timestamp: new Date(timestamp).toISOString(),
           thresholdResult: {
             definition: thresholds,

workspaces/scorecard/plugins/scorecard-node/src/api/MetricProvider.ts

@@ -28,7 +28,7 @@ import {
 export type MetricProviderInsertion = {
   catalog_entity_ref: string;
   metric_id: string;
-  value?: number;
+  value?: MetricValue;
   timestamp: Date;
   error_message?: string;
 };