chore(e2e): rhidp-8750 Re-enable Disabled E2E Tests in the Project (#3327)

* fix: update placeholder text from "Search" to "Filter" in dynamic-plugins-info.spec.ts

* test: skip tests for Github Discovery Catalog and TLS config health check

* test: skip failing tests in Github Discovery and Topology RBAC specs

* test: remove TODO comments for plugin-todo-list test

Author: gustavolira

e2e-tests/playwright/e2e/extensions.spec.ts

@@ -148,77 +148,4 @@ test.describe("Admin > Extensions > Catalog", () => {
     await expect(page.getByRole("button", { name: "View" })).toBeVisible();
     await uiHelper.verifyHeading("Application Topology for Kubernetes");
   });
-
-  // Enable this when the plugin is installation is enabled in the production environment
-  test.skip("Verify plugin configuration is editable and can be enabled when disabled", async ({
-    page,
-  }) => {
-    await uiHelper.searchInputPlaceholder("Topology");
-    await page.getByRole("heading", { name: "Topology" }).first().click();
-    await uiHelper.verifyHeading("Application Topology for Kubernetes");
-    await uiHelper.clickButton("Actions");
-    await uiHelper.clickByDataTestId("edit-configuration");
-    await uiHelper.verifyHeading(
-      "Edit Application Topology for Kubernetes configurations",
-    );
-    await uiHelper.verifyText(
-      "- package: ./dynamic-plugins/dist/backstage-community-plugin-topology",
-    );
-    await uiHelper.verifyText("disabled: false");
-    await uiHelper.verifyText("Apply");
-    await uiHelper.verifyHeading("Default configuration");
-    await uiHelper.clickButton("Apply");
-    await uiHelper.verifyText("pluginConfig:");
-    await uiHelper.verifyText("dynamicPlugins:");
-    await uiHelper.clickTab("About the plugin");
-    await uiHelper.verifyHeading("Configuring The Plugin");
-    await uiHelper.clickTab("Examples");
-    await uiHelper.clickByDataTestId("ContentCopyRoundedIcon");
-    await expect(page.getByRole("button", { name: "✔" })).toBeVisible();
-    await uiHelper.clickButton("Reset");
-    await expect(page.getByText("pluginConfig:")).not.toBeVisible();
-    const modifier = isMac ? "Meta" : "Control";
-    await page.keyboard.press(`${modifier}+KeyA`);
-    await page.keyboard.press(`${modifier}+KeyV`);
-    await uiHelper.verifyText("pluginConfig:");
-    await page.locator("button[class^='copy-button']").click();
-    await expect(page.getByRole("button", { name: "✔" }).nth(1)).toBeVisible();
-    const clipboardContent = await page.evaluate(() =>
-      navigator.clipboard.readText(),
-    );
-    expect(clipboardContent).not.toContain("pluginConfig:");
-    expect(clipboardContent).toContain("backstage-community.plugin-topology:");
-    await uiHelper.clickButton("Save");
-    await uiHelper.verifyHeading("Extensions");
-    let alert = page.getByRole("alert").first();
-    expect(alert).toContainText("Backend restart required");
-    expect(alert).toContainText(
-      "The Application Topology for Kubernetes plugin requires a restart of the backend system to finish installing, updating, enabling or disabling.",
-    );
-    await uiHelper.searchInputPlaceholder("Argo CD Software Template Actions");
-    await page
-      .getByRole("heading", { name: "Argo CD Software Template Actions" })
-      .first()
-      .click();
-
-    await uiHelper.clickButton("Actions");
-    await uiHelper.clickByDataTestId("enable-plugin");
-    await uiHelper.verifyHeading("Extensions");
-    alert = page.getByRole("alert").first();
-    expect(alert).toContainText("Backend restart required");
-    expect(alert).toContainText(
-      "You have 2 plugins that require a restart of your backend system to either finish installing, updating, enabling or disabling.",
-    );
-    page.getByText("View plugins", { exact: true }).click();
-    const rowLocator = page.locator(`tbody>tr`).nth(1);
-    await rowLocator.waitFor({ state: "visible" });
-    const nameCell = rowLocator.locator("th");
-    const actionCell = rowLocator.locator("td");
-    await expect(nameCell).toHaveText("Argo CD Software Template Actions");
-    await expect(actionCell).toContainText("Plugin enabled");
-    await uiHelper.verifyText(
-      "To finish the plugin modifications, restart your backend system.",
-    );
-    await uiHelper.clickButton("Close");
-  });
 });

e2e-tests/playwright/e2e/plugins/dynamic-plugins-info/dynamic-plugins-info.spec.ts

@@ -69,13 +69,11 @@ test.describe("dynamic-plugins-info UI tests", () => {
     expect(await row.locator("td").nth(3).innerText()).toBe("Yes"); // preinstalled
   });
 
-  // TODO: Enable this test once the behavior for loading this plugin is fixed.
-  // TODO: In RHDH 1.5, this plugin incorrectly appears as disabled despite being properly imported and explicitly enabled.
-  test.skip("it should have a plugin-todo-list plugin which is Enabled but not Preinstalled", async ({
+  test("it should have a plugin-todo-list plugin which is Enabled but not Preinstalled", async ({
     page,
   }) => {
     await page
-      .getByPlaceholder("Search", { exact: true })
+      .getByPlaceholder("Filter", { exact: true })
       .pressSequentially("plugin-todo\n", { delay: 300 });
 
     // Verify the Enabled and Preinstalled column values for the specific row

e2e-tests/playwright/e2e/plugins/topology/topology-rbac.spec.ts

@@ -57,25 +57,22 @@ test.describe("Test Topology Plugin with RBAC", () => {
 
   // User is able to read from the catalog
   // User has 'kubernetes.clusters.read', 'kubernetes.resources.read', 'kubernetes.proxy' permissions
-  test.describe.skip(
-    "Verify a user with permissions is able to access the Topology plugin",
-    () => {
-      //Skipping for now as it is failing RHIDP-7164
-      test.beforeEach(async () => {
-        await common.loginAsKeycloakUser();
+  test.describe("Verify a user with permissions is able to access the Topology plugin", () => {
+    //Skipping for now as it is failing RHIDP-7164
+    test.beforeEach(async () => {
+      await common.loginAsKeycloakUser();
 
-        await catalog.goToBackstageJanusProject();
-        await uiHelper.clickTab("Topology");
-      });
+      await catalog.goToBackstageJanusProject();
+      await uiHelper.clickTab("Topology");
+    });
 
-      test("Verify pods visibility in the Topology tab", async () => {
-        await topology.verifyDeployment("topology-test");
-      });
+    test("Verify pods visibility in the Topology tab", async () => {
+      await topology.verifyDeployment("topology-test");
+    });
 
-      test("Verify pod logs visibility in the Topology tab", async () => {
-        await topology.verifyDeployment("topology-test");
-        await topology.verifyPodLogs(true);
-      });
-    },
-  );
+    test("Verify pod logs visibility in the Topology tab", async () => {
+      await topology.verifyDeployment("topology-test");
+      await topology.verifyPodLogs(true);
+    });
+  });
 });