Skip to content

Commit cd9fc72

Browse files
committed
don't hide the name as it's now required
1 parent 3d232d8 commit cd9fc72

File tree

2 files changed

+8
-18
lines changed

2 files changed

+8
-18
lines changed

redisinsight/api/src/modules/rdi/utils/pipeline.util.spec.ts

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,11 @@ describe('convertApiDataToRdiJobs', () => {
4040
const jobs = [job1, job2] as unknown as [Record<string, any>];
4141
const result = convertApiDataToRdiJobs(jobs);
4242
expect(result).toEqual({
43-
[job1.name]: { ...job1, name: undefined },
44-
[job2.name]: { ...job2, name: undefined },
43+
[job1.name]: job1,
44+
[job2.name]: job2,
4545
});
4646
});
4747

48-
it('should remove the name property from each job', () => {
49-
const jobs = [job1, job2] as unknown as [Record<string, any>];
50-
const result = convertApiDataToRdiJobs(jobs);
51-
expect(result.job1.name).toBeUndefined();
52-
expect(result.job2.name).toBeUndefined();
53-
});
54-
5548
it('should ignore jobs without a name property', () => {
5649
const jobWithoutName = {
5750
source: {
@@ -63,7 +56,7 @@ describe('convertApiDataToRdiJobs', () => {
6356
const jobs = [jobWithoutName, job2] as unknown as [Record<string, any>];
6457
const result = convertApiDataToRdiJobs(jobs);
6558
expect(result).toEqual({
66-
[job2.name]: { ...job2, name: undefined },
59+
[job2.name]: job2,
6760
});
6861
});
6962
});
@@ -88,8 +81,8 @@ describe('convertApiDataToRdiPipeline', () => {
8881
processors: undefined,
8982
},
9083
jobs: {
91-
[job1.name]: { ...job1, name: undefined },
92-
[job2.name]: { ...job2, name: undefined },
84+
[job1.name]: job1,
85+
[job2.name]: job2,
9386
},
9487
});
9588

@@ -142,8 +135,8 @@ describe('convertApiDataToRdiPipeline', () => {
142135
processors: undefined,
143136
},
144137
jobs: {
145-
job1: { ...job1, name: undefined },
146-
job2: { ...job2, name: undefined },
138+
job1: job1,
139+
job2: job2,
147140
},
148141
});
149142

redisinsight/api/src/modules/rdi/utils/pipeline.util.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ export const convertApiDataToRdiJobs = (
1010
if (jobs && isArray(jobs)) {
1111
jobs.forEach((job) => {
1212
if (job?.name) {
13-
jobsMap[job.name] = {
14-
...job,
15-
name: undefined, // do not show name in the config area
16-
};
13+
jobsMap[job.name] = job;
1714
}
1815
});
1916
}

0 commit comments

Comments
 (0)