Skip to content

fix: add missing error variable for non-unix build constraints #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

fix: add missing error variable for non-unix build constraints #3538

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3979f1d
fix: add missing error variable for non-unix build constraints
huiyifyj Sep 27, 2025
3426e04
chore: name "_" for unused parameters
huiyifyj Sep 28, 2025
488779f
Merge branch 'master' into undefine-err-var-non-unix
elena-kolevska Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions internal/pool/conn_check_dummy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@

package pool

import "net"
import (
"errors"
"net"
)

func connCheck(conn net.Conn) error {
// errUnexpectedRead is placeholder error variable for non-unix build constraints
var errUnexpectedRead = errors.New("unexpected read from socket")

func connCheck(_ net.Conn) error {
return nil
}

// since we can't check for data on the socket, we just assume there is some
func maybeHasData(conn net.Conn) bool {
func maybeHasData(_ net.Conn) bool {
return true
}
Loading