declareType function missing checks

[m5x5]

remotestorage.js/src/baseclient.ts

Lines 734 to 747 in be39e4e

	declareType (alias: string, uriOrSchema: string|tv4.JsonSchema, schema?: tv4.JsonSchema): void {
	let uri: string;
	if (schema && typeof uriOrSchema === 'string') {
	uri = uriOrSchema;
	} else if (!schema && typeof uriOrSchema !== 'string') {
	schema = uriOrSchema;
	uri = this._defaultTypeURI(alias);
	} else if (!schema && typeof uriOrSchema === 'string') {
	throw new Error('declareType() requires a JSON Schema object to be passed, in order to validate object types/formats');
	}
	BaseClient.Types.declare(this.moduleName, alias, uri, schema);
	}

I'm currently working on bringing remotestorage to Java (to learn the language) and noticed that there might be an error when schema is given but uriOrSchema is null.

[raucao]

If you look closely at the TypeScript argument definition, it defines that you always have to pass uriOrSchema, but schema is an optional argument (for when you already passed a schema in uriOrSchema).

The idea is that if you don't give it a URI, then the URI is created (and added to objects) automatically by the library.

FWIW, I think it's always been confusing to work with, and the only reason it's still the same is not having to introduce a major breaking change, which would affect most apps and data modules.

Does that make sense to you?

[m5x5]

Oh I see, yeah, it makes sense, thank you!