different CN/solver interaction for SMT counter models #240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CN used to create a new solver instance for each model. This means solver models can be passed around as values and interacted with later, but also complicates the Solver module. With this change, CN models are just references to the current solver state (so creating a model no longer creates a new solver instance). This means the timing of when CN queries the model matters, and type error reports including countermodel information have to be produced when the model is still "live". This change temporarily disables the CheckPredicates logic, which relies on asking new solver queries, which then override the present model -- to be fixed.