Skip to content

Commit 00067b5

Browse files
authored
Adjusts caching on the EC version to avoid errors (#358)
TL;DR ----- Updates the function for fetching the EC version to check the right variable when catching Details ------- We were getting some download errors on the Embedded Cluster. It was sporadic and there were a couple of options. The first was GitHub rate limits, which may still be a factor. The second was that the version was either not being fetched or being fetched incorrectly. Investigating the second option, I realized that the code that checked the runtime variable for the version was checking the wrong variable. This change checks the right variable there. I'm not 100% sure this will be a lasting fix to the issue, but it was a bug and it was in the right area. The code also updates the track checksum (since it changes with every push) and fixes an error where the config help text had some variable interpolation problems.
1 parent 6936fa2 commit 00067b5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

instruqt/delivering-as-an-appliance/03-collecting-configuration/setup-shell

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ spec:
3131
and the user who can administer it.
3232
3333
Users that you specify under **Admin Users** will be able to access the
34-
Slackernews adminstrative console at `/admin`, allowing them to manage
34+
Slackernews adminstrative console at \`/admin\`, allowing them to manage
3535
content, users, and settings. Changes will take effect the next time
3636
they are active in the Slackernews application.
3737
items:
3838
- name: slackernews_domain
3939
title: Ingress Hostname
4040
help_text: >
4141
The domain name at which you'll access SlackerNews. Don't include
42-
the `https://` or any path elements.
42+
the \`https://\` or any path elements.
4343
type: text
4444
required: true
4545
validation:

instruqt/delivering-as-an-appliance/track.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,4 @@ lab_config:
4747
hideStopButton: false
4848
default_layout: AssignmentRight
4949
default_layout_sidebar_size: 25
50-
checksum: "8888110905668754440"
50+
checksum: "10811747556592817534"

libs/header.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ get_replicated_sdk_version () {
5050

5151
get_embedded_cluster_version () {
5252
set +eu pipefail
53-
replicated_sdk_version=$(agent variable get REPLICATED_SDK_VERSION)
53+
embedded_cluster_version=$(agent variable get EMBEDDED_CLUSTER_VERSION)
5454

5555
# if we don't already have a token, fetch one
56-
if [[ -z "$replicated_sdk_version" ]]; then
56+
if [[ -z "$empedded_cluster_version" ]]; then
5757
embedded_cluster_version=$(curl -s "https://api.github.com/repos/replicatedhq/embedded-cluster/releases/latest" | jq -r .tag_name)
5858
fi
5959

0 commit comments

Comments
 (0)