Skip to content

Enabled plantuml interactive #7179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oneacik wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −3
Open

Enabled plantuml interactive #7179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion client/components/editor/markdown/plantuml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ module.exports = {
const closeChar = closeMarker.charCodeAt(0)
const imageFormat = opts.imageFormat || 'svg'
const server = opts.server || 'https://plantuml.requarks.io'
const renderSvgAsObject = opts.renderSvgAsObject || false

md.block.ruler.before('fence', 'uml_diagram', (state, startLine, endLine, silent) => {
let nextLine
Expand Down Expand Up @@ -134,7 +135,8 @@ module.exports = {
openMarker: conf.openMarker,
closeMarker: conf.closeMarker,
imageFormat: conf.imageFormat,
server: conf.server
server: conf.server,
renderSvgAsObject: conf.renderSvgAsObject
})
}
}
Expand Down
7 changes: 7 additions & 0 deletions server/modules/rendering/markdown-plantuml/definition.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,10 @@ props:
- ascii
order: 4
public: true
renderSvgAsObject:
type: Boolean
default: false
title: Render svg as object tag instead of img tag
hint: Allows for interactive content like links in plantuml graphs - it may have security implications
order: 5
public: true
15 changes: 13 additions & 2 deletions server/modules/rendering/markdown-plantuml/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ module.exports = {
const closeChar = closeMarker.charCodeAt(0)
const imageFormat = opts.imageFormat || 'svg'
const server = opts.server || 'https://plantuml.requarks.io'
const renderSvgAsObject = opts.renderSvgAsObject || false

md.block.ruler.before('fence', 'uml_diagram', (state, startLine, endLine, silent) => {
let nextLine
Expand Down Expand Up @@ -129,12 +130,22 @@ module.exports = {
}, {
alt: [ 'paragraph', 'reference', 'blockquote', 'list' ]
})
md.renderer.rules.uml_diagram = md.renderer.rules.image
if (renderSvgAsObject && imageFormat === 'svg') {
md.renderer.rules.uml_diagram = (tokens, idx) => {
const currentToken = tokens[idx]
const src = currentToken.attrGet('src')
const clazz = currentToken.attrGet('class')
return `<object data='${src}' class="${clazz}"></object>`
}
} else {
md.renderer.rules.uml_diagram = md.renderer.rules.image
}
}, {
openMarker: conf.openMarker,
closeMarker: conf.closeMarker,
imageFormat: conf.imageFormat,
server: conf.server
server: conf.server,
renderSvgAsObject: conf.renderSvgAsObject
})
}
}
Expand Down