Merge pull request #3 from rhythmictech/s3-bucket-policy-fix

smiller171 · web-flow · commit 13190231e011 · 2020-09-10T17:20:31.000-04:00
make s3_public_access_block depend on bucket_policy
diff --git a/main.tf b/main.tf
@@ -54,7 +54,10 @@ resource "aws_s3_bucket_public_access_block" "this" {
     create_before_destroy = true
   }
 
-  depends_on = [aws_s3_bucket.this]
+  depends_on = [
+    aws_s3_bucket.this,
+    aws_s3_bucket_policy.this
+  ]
 }
 
 data "aws_iam_policy_document" "this" {

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,10 @@ resource "aws_s3_bucket_public_access_block" "this" {`
`54`	`54`	`create_before_destroy = true`
`55`	`55`	`}`
`56`	`56`
`57`		`- depends_on = [aws_s3_bucket.this]`
	`57`	`+ depends_on = [`
	`58`	`+ aws_s3_bucket.this,`
	`59`	`+ aws_s3_bucket_policy.this`
	`60`	`+ ]`
`58`	`61`	`}`
`59`	`62`
`60`	`63`	`data "aws_iam_policy_document" "this" {`