Skip to content

perf: improve bytes serialization performance #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v0y4g3r wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: improve bytes serialization performance #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb01005
perf/serialize-bytes:
v0y4g3r Aug 25, 2025
451c093
also optimize flip cases
v0y4g3r Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions benches/serde.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,41 @@
// See the License for the specific language governing permissions and
// limitations under the License.

use criterion::{criterion_group, criterion_main, Criterion};
use criterion::{black_box, criterion_group, criterion_main, Criterion};
use memcomparable::Serializer;
use serde::Serializer as _;

criterion_group!(benches, decimal);
criterion_group!(benches, decimal, bytes);
criterion_main!(benches);

#[cfg(not(feature = "decimal"))]
fn decimal(_c: &mut Criterion) {}

fn bytes(c: &mut Criterion) {
let mut group = c.benchmark_group("bytes");

for size in [10, 100, 1000] {
let bytes = (0..size).map(|_| rand::random::<u8>()).collect::<Vec<_>>();
group.bench_function(format!("size-{}", size), |b| {
b.iter(|| {
let mut s = Serializer::new(Vec::with_capacity(size / 8 * 9));
s.serialize_bytes(&bytes).unwrap();
black_box(s);
});
});

group.bench_function(format!("size-{}-reverse", size), |b| {
b.iter(|| {
let mut s = Serializer::new(Vec::with_capacity(size / 8 * 9));
s.set_reverse(true);
s.serialize_bytes(&bytes).unwrap();
black_box(s);
});
});
}
group.finish();
}

#[cfg(feature = "decimal")]
fn decimal(c: &mut Criterion) {
use memcomparable::{Decimal, Deserializer, Serializer};
Expand Down
36 changes: 33 additions & 3 deletions src/ser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,39 @@ impl<B: BufMut> MaybeFlip<B> {
def_method!(put_u128, u128);

fn put_slice(&mut self, src: &[u8]) {
for &val in src {
let val = if self.flip { !val } else { val };
self.output.put_u8(val);
if !self.flip {
let num_chunks = src.len() / 8;
let remainder = src.len() % 8;
let mut tmp = [0u8; 8];
for chunk in 0..num_chunks {
for idx in 0..8 {
tmp[idx] = src[chunk * 8 + idx];
}
self.output.put_slice(&tmp);
}
if remainder != 0 {
for idx in 0..remainder {
tmp[idx] = src[num_chunks * 8 + idx];
}
self.output.put_slice(&tmp[0..remainder]);
}
Comment on lines +83 to +97
Copy link
Contributor

@xiangjinwu xiangjinwu Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not self.output.put_slice(src)?

} else {
let num_chunks = src.len() / 8;
let remainder = src.len() % 8;
let mut tmp = [0u8; 8];
for chunk in 0..num_chunks {
for idx in 0..8 {
tmp[idx] = !src[chunk * 8 + idx];
}
self.output.put_slice(&tmp);
}

if remainder != 0 {
for idx in 0..remainder {
tmp[idx] = !src[num_chunks * 8 + idx];
}
self.output.put_slice(&tmp[0..remainder]);
}
}
}

Expand Down