fix(container-runner): fix leaked pipes

Author: NathanFlurry

packages/edge/infra/client/container-runner/src/container.rs

@@ -84,20 +84,22 @@ pub fn run(
 	//
 	// This will wait for the child to exit and then exit itself so we have time to ship all of the
 	// required logs
-	let mut signals = Signals::new(&[SIGTERM])?;
-	thread::spawn(move || {
-		for _ in signals.forever() {
-			println!("Received SIGTERM, forwarding to runc container {actor_id}");
-			let status = Command::new("runc")
-				.arg("kill")
-				.arg("--all")
-				.arg(&actor_id)
-				.arg("SIGTERM")
-				.status();
-			println!("runc kill status: {:?}", status);
-			break;
-		}
-	});
+	//let mut signals = Signals::new(&[SIGTERM])?;
+	//thread::spawn(move || {
+	//	for _ in signals.forever() {
+	//		println!("Received SIGTERM, forwarding to runc container {actor_id}");
+	//		let status = Command::new("runc")
+	//			.arg("kill")
+	//			.arg("--all")
+	//			.arg(&actor_id)
+	//			.arg("SIGTERM")
+	//			.stdout(Stdio::null())
+	//			.stderr(Stdio::null())
+	//			.status();
+	//		println!("runc kill status: {:?}", status);
+	//		break;
+	//	}
+	//});
 
 	// Ship stdout & stderr logs
 	let stdout_handle = ship_logs(msg_tx.clone(), log_shipper::StreamType::StdOut, runc_stdout);

packages/edge/infra/client/container-runner/tests/common/setup.rs

@@ -24,6 +24,8 @@ impl Setup {
 	pub fn signal_child(&self, signal: &str) {
 		let kill = Command::new("kill")
 			.args(["-s", signal, &self.child.id().to_string()])
+			.stdout(std::process::Stdio::null())
+			.stderr(std::process::Stdio::null())
 			.status()
 			.unwrap();
 		assert!(kill.success());
@@ -37,6 +39,8 @@ impl Drop for Setup {
 			.arg("delete")
 			.arg("--force")
 			.arg(&self.actor_id)
+			.stdout(std::process::Stdio::null())
+			.stderr(std::process::Stdio::null())
 			.status()
 			.unwrap();
 
@@ -64,6 +68,8 @@ pub fn setup(command: &str) -> Setup {
 		.arg("docker://debian:12.4")
 		.arg("oci:oci-image:latest")
 		.current_dir(actor_dir.path())
+		.stdout(std::process::Stdio::null())
+		.stderr(std::process::Stdio::null())
 		.status()
 		.unwrap();
 	assert!(status.success());
@@ -74,6 +80,8 @@ pub fn setup(command: &str) -> Setup {
 		.arg("oci-image:latest")
 		.arg("fs")
 		.current_dir(actor_dir.path())
+		.stdout(std::process::Stdio::null())
+		.stderr(std::process::Stdio::null())
 		.status()
 		.unwrap();
 	assert!(status.success());