-
Notifications
You must be signed in to change notification settings - Fork 114
chore: fix dc wf #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MasterPtato
wants to merge
1
commit into
06-02-chore_vector_add_vector_pipeline_to_ship_clickhouse_events_from_the_edge
from
06-05-chore_fix_dc_wf
Closed
chore: fix dc wf #2552
MasterPtato
wants to merge
1
commit into
06-02-chore_vector_add_vector_pipeline_to_ship_clickhouse_events_from_the_edge
from
06-05-chore_fix_dc_wf
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2025
This was referenced Jun 5, 2025
Closed
This was referenced Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR primarily focuses on workflow improvements and code cleanup in the datacenter and actor services. The main changes include:
- Refactored
cluster_datacenter
workflow inmod.rs
to handle database version migrations with guard public hostname support - Improved
ServerState
enum formatting intypes.rs
for better readability - Removed unused imports (
AsHashableExt
,analytics::InsertClickHouseInput
) from pegboard service files - Cleaned up trailing newlines in Vector configuration script
- Consolidated database version handling to address hash calculation issues
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
Latest commit: |
3cc4b5f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://793edfa0.rivet.pages.dev |
Branch Preview URL: | https://06-05-chore-fix-dc-wf.rivet.pages.dev |
Deploying rivet-hub with
|
Latest commit: |
3cc4b5f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://003111e6.rivet-hub-7jb.pages.dev |
Branch Preview URL: | https://06-05-chore-fix-dc-wf.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
Latest commit: |
3cc4b5f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3fc14323.rivet-studio.pages.dev |
Branch Preview URL: | https://06-05-chore-fix-dc-wf.rivet-studio.pages.dev |
0d2ca27
to
7a2a9b2
Compare
b43c653
to
a32e202
Compare
This was referenced Jun 6, 2025
7a2a9b2
to
3cc4b5f
Compare
a32e202
to
526f37e
Compare
This was referenced Jun 6, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes