chore(guard): fix log levels #2580

MasterPtato · 2025-06-10T21:04:53Z

Changes

MasterPtato · 2025-06-10T21:05:04Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

feat(toolchain): remote build method #2579 : 2 dependent PRs (#2583 , #2601 )
fix(api): handle wrapped operation errors #2602
chore(pegboard): fix local cache bugs #2596
fix(cluster): fix pbi autoscaling #2592
feat(pegboard): add local image cache and overlay fs mounts #2586
chore(guard): fix log levels #2580 👈 (View in Graphite)
feat: db sh for workflows #2570
fix(pegboard): fix enabling root users #2572
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

Comprehensive update to logging levels across the guard infrastructure to improve production log signal-to-noise ratio and maintainability.

Downgraded routine operations (WebSocket connections, request handling) from info to debug in packages/edge/infra/guard/core/src/proxy_service.rs
Upgraded configuration failures to warn level and enhanced error formatting with ?err syntax in packages/edge/infra/guard/server/src/tls.rs
Removed unused imports (tracing::warn, regex::Regex) from request context and util files
Standardized error variable naming from e to err across multiple files for consistency
Improved structured logging patterns and upgraded routing timeouts from warn to error in proxy service

_{7 files reviewed, 2 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-06-10T21:05:42Z

packages/edge/infra/guard/core/src/server.rs

+					tracing::error!("{} connection error: {}", port_type_str, err);
 				}
-				info!("{} connection dropped: {}", port_type_str, remote_addr);
+				tracing::debug!("{} connection dropped: {}", port_type_str, remote_addr);


style: Consider adding structured logging fields here to make connection errors more easily parseable. Use the ?err syntax like other error logs in this file.

Suggested change

tracing::error!("{} connection error: {}", port_type_str, err);

}

info!("{} connection dropped: {}", port_type_str, remote_addr);

tracing::debug!("{} connection dropped: {}", port_type_str, remote_addr);

if let Err(err) = conn.await {

tracing::error!(?err, "{} connection error", port_type_str);

}

tracing::debug!("{} connection dropped: {}", port_type_str, remote_addr);

greptile-apps · 2025-06-10T21:05:43Z

packages/edge/infra/guard/core/src/proxy_service.rs

 									},
-									Some(Err(e)) => {
+									Some(Err(err)) => {
 										// Error receiving message from client
-										error!("Error receiving message from client: {}", e);
-										error!("Error details: {:?}", e);
+										tracing::debug!(?err, "Error receiving message from client");
+										tracing::debug!(?err, "Error details");
 										// Signal shutdown to other direction
 										let _ = shutdown_tx.send(true);
 										break;
 									},


style: Duplicate error logging removed - the first log line already includes error details through ?err

Suggested change

},

Some(Err(e)) => {

Some(Err(err)) => {

// Error receiving message from client

error!("Error receiving message from client: {}", e);

error!("Error details: {:?}", e);

tracing::debug!(?err, "Error receiving message from client");

tracing::debug!(?err, "Error details");

// Signal shutdown to other direction

let _ = shutdown_tx.send(true);

break;

},

},

Some(Err(err)) => {

// Error receiving message from client

tracing::debug!(?err, "Error receiving message from client");

// Signal shutdown to other direction

let _ = shutdown_tx.send(true);

break;

},

cloudflare-workers-and-pages · 2025-06-10T21:06:03Z

Deploying rivet with Cloudflare Pages

Latest commit:	`84aaf41`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-06-12T01:40:08Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`84aaf41`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-06-12T01:40:29Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`84aaf41`
Status:	🚫 Build failed.

View logs

graphite-app · 2025-06-20T19:19:39Z

Merge activity

Jun 20, 7:19 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
Jun 20, 7:20 PM UTC: CI is running for this pull request on a draft pull request (#2630) due to your merge queue CI optimization settings.
Jun 20, 7:22 PM UTC: Merged by the Graphite merge queue via draft PR: #2630.

## Changes

MasterPtato requested a review from NathanFlurry June 10, 2025 21:04

MasterPtato mentioned this pull request Jun 10, 2025

feat: db sh for workflows #2570

Closed

greptile-apps bot reviewed Jun 10, 2025

View reviewed changes

MasterPtato force-pushed the 06-10-chore_guard_fix_log_levels branch from fa955f0 to b3aa8b4 Compare June 12, 2025 01:37

MasterPtato force-pushed the 06-07-feat_db_sh_for_workflows branch from ef7fce9 to 2bdeefd Compare June 12, 2025 01:37

MasterPtato mentioned this pull request Jun 12, 2025

feat(pegboard): add local image cache and overlay fs mounts #2586

Closed

MasterPtato changed the base branch from 06-07-feat_db_sh_for_workflows to graphite-base/2580 June 12, 2025 21:21

MasterPtato changed the base branch from graphite-base/2580 to 06-07-feat_db_sh_for_workflows June 12, 2025 22:30

MasterPtato force-pushed the 06-07-feat_db_sh_for_workflows branch from 2bdeefd to fba1301 Compare June 12, 2025 23:04

MasterPtato force-pushed the 06-10-chore_guard_fix_log_levels branch from b3aa8b4 to 2e8e98f Compare June 12, 2025 23:04

MasterPtato changed the base branch from 06-07-feat_db_sh_for_workflows to graphite-base/2580 June 13, 2025 18:10

MasterPtato mentioned this pull request Jun 13, 2025

fix(cluster): fix pbi autoscaling #2592

Closed

MasterPtato changed the base branch from graphite-base/2580 to 06-07-feat_db_sh_for_workflows June 13, 2025 20:43

MasterPtato mentioned this pull request Jun 13, 2025

chore(pegboard): fix local cache bugs #2596

Closed

MasterPtato force-pushed the 06-10-chore_guard_fix_log_levels branch from 2e8e98f to 4a380a5 Compare June 13, 2025 22:55

MasterPtato force-pushed the 06-07-feat_db_sh_for_workflows branch from fba1301 to 84f7df4 Compare June 13, 2025 22:55

MasterPtato mentioned this pull request Jun 13, 2025

fix(api): handle wrapped operation errors #2602

Closed

NathanFlurry force-pushed the 06-07-feat_db_sh_for_workflows branch from 84f7df4 to cfc30cf Compare June 15, 2025 20:24

NathanFlurry force-pushed the 06-10-chore_guard_fix_log_levels branch from 4a380a5 to 84aaf41 Compare June 15, 2025 20:24

abcxff force-pushed the 06-10-chore_guard_fix_log_levels branch from a8d0391 to bc3dd6c Compare June 18, 2025 16:37

MasterPtato force-pushed the 06-10-chore_guard_fix_log_levels branch from bc3dd6c to a8d0391 Compare June 18, 2025 23:47

This was referenced Jun 19, 2025

fix: figure out actor log shipping #2622

Closed

fix: get new actors working on docker compose #2623

Closed

NathanFlurry force-pushed the 06-07-feat_db_sh_for_workflows branch from 01bc6a9 to cfc30cf Compare June 20, 2025 18:54

NathanFlurry force-pushed the 06-10-chore_guard_fix_log_levels branch from a8d0391 to 84aaf41 Compare June 20, 2025 18:54

MasterPtato force-pushed the 06-10-chore_guard_fix_log_levels branch from 84aaf41 to c33d751 Compare June 20, 2025 19:09

MasterPtato force-pushed the 06-07-feat_db_sh_for_workflows branch from cfc30cf to a3cf488 Compare June 20, 2025 19:09

chore(guard): fix log levels

5b30dea

NathanFlurry force-pushed the 06-07-feat_db_sh_for_workflows branch from a3cf488 to 6ce34ef Compare June 20, 2025 19:18

NathanFlurry force-pushed the 06-10-chore_guard_fix_log_levels branch from c33d751 to 5b30dea Compare June 20, 2025 19:18

graphite-app bot pushed a commit that referenced this pull request Jun 20, 2025

chore(guard): fix log levels (#2580)

c1c57ff

 ## Changes

graphite-app bot closed this Jun 20, 2025

graphite-app bot deleted the 06-10-chore_guard_fix_log_levels branch June 20, 2025 19:22

github-actions bot mentioned this pull request Jun 20, 2025

chore(main): release 25.5.1 #2423

Merged

NathanFlurry mentioned this pull request Jun 20, 2025

chore: fix merge conflicts #2634

Closed

This was referenced Jun 20, 2025

fix: add udp ports to docker compose #2635

Closed

feat: get multi actors working e2e on docker compose #2637

Closed

feat: add actor kv to runners #2638

Closed

feat: add actor queue #2644

Closed

fix: fix logs for new actors #2649

Closed

This was referenced Jun 28, 2025

fix(guard): use intercom_address for guard service discovery #2663

Closed

feat(actors): expose container system metrics #2664

Closed

chore: cargo fmt #2665

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(guard): fix log levels #2580

chore(guard): fix log levels #2580

Uh oh!

MasterPtato commented Jun 10, 2025

Uh oh!

MasterPtato commented Jun 10, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

greptile-apps bot Jun 10, 2025

Uh oh!

cloudflare-workers-and-pages bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jun 12, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Jun 12, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chore(guard): fix log levels #2580

chore(guard): fix log levels #2580

Uh oh!

Conversation

MasterPtato commented Jun 10, 2025

Changes

Uh oh!

MasterPtato commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

graphite-app bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MasterPtato commented Jun 10, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 10, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 12, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 12, 2025 •

edited

Loading

graphite-app bot commented Jun 20, 2025 •

edited

Loading