feat(pegboard): add local image cache and overlay fs mounts #2586

MasterPtato · 2025-06-12T01:37:44Z

Changes

MasterPtato · 2025-06-12T01:37:55Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

feat(toolchain): remote build method #2579 : 2 dependent PRs (#2583 , #2601 )
fix(api): handle wrapped operation errors #2602
chore(pegboard): fix local cache bugs #2596
fix(cluster): fix pbi autoscaling #2592
feat(pegboard): add local image cache and overlay fs mounts #2586 👈 (View in Graphite)
chore(guard): fix log levels #2580
feat: db sh for workflows #2570
fix(pegboard): fix enabling root users #2572
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-06-12T01:43:06Z

Deploying rivet with Cloudflare Pages

Latest commit:	`ff90f58`
Status:	🚫 Build failed.

View logs

MasterPtato · 2025-06-12T22:31:33Z

@greptileai

greptile-apps

PR Summary

Major enhancement to Pegboard's container image management system, introducing local image caching and overlay filesystem mounts for improved performance and resource utilization.

Added ImageDownloadHandler in packages/edge/infra/client/manager/src/image_download_handler.rs with LRU-based caching and concurrent download management using SCC HashMap
Implemented overlay filesystem mounts in packages/edge/infra/client/manager/src/actor/setup.rs to share common layers between actors using the same image
Added high-priority scheduling (Nice=-15) for critical services in systemd configurations for rivet-edge-server, pegboard, and rivet-guard
Added granular histogram buckets in packages/edge/infra/client/manager/src/metrics/buckets.rs for microsecond-scale performance measurements
Restructured actor identification to use (actor_id, generation) tuples across multiple test files for better lifecycle management

_{34 files reviewed, 11 comments}
_{Edit PR Review Bot Settings | Greptile}

packages/edge/infra/client/manager/tests/container_lifecycle.rs

packages/edge/infra/client/manager/tests/client_state_external_kill.rs

packages/edge/services/pegboard/standalone/usage-metrics-publish/src/lib.rs

packages/edge/infra/client/manager/src/utils/libc.rs

packages/edge/infra/client/manager/tests/common.rs

packages/edge/infra/client/manager/src/metrics/mod.rs

packages/edge/infra/client/manager/src/image_download_handler.rs

packages/edge/infra/client/manager/src/utils/mod.rs

greptile-apps

PR Summary

Further refinements to the Pegboard image caching system and actor lifecycle management, focusing on resource optimization and service reliability.

Refactored actor port management in tests/ to remove explicit port assignments, suggesting a more dynamic port allocation system
Phased out isolate-v8 runner in favor of container-based runners, with related test updates in packages/edge/infra/client/manager/tests/common.rs
Added process resource controls in packages/edge/infra/client/manager/src/runner.rs for better CPU and memory management of orphaned processes
Optimized CPU shares calculation in packages/edge/infra/client/manager/src/actor/oci_config.rs by adjusting divisor from 8 to 10
Added datacenter validation before metrics collection in packages/edge/services/pegboard/standalone/usage-metrics-publish/src/lib.rs

_{34 files reviewed, 2 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-06-12T22:32:06Z

tests/load/actor-lifecycle/index.ts

+
+		// Sleep if not disabled
+		if (!CONFIG.disableSleep) {
+			const sleepDuration = (start + 60_000 - Date.now()) / 1000;


logic: Using shadowed 'start' variable here. Will calculate wrong sleep duration. Should use outer 'start' variable.

Suggested change

const sleepDuration = (start + 60_000 - Date.now()) / 1000;

const sleepDuration = (actorStart + 60_000 - Date.now()) / 1000;

packages/edge/infra/client/echo/src/main.rs

cloudflare-workers-and-pages · 2025-06-13T23:01:20Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`ff90f58`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-06-13T23:01:35Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`a94aa4a`
Status:	⚡️ Build in progress...

View logs

graphite-app · 2025-06-20T19:19:40Z

Merge activity

Jun 20, 7:19 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
Jun 20, 7:20 PM UTC: CI is running for this pull request on a draft pull request (#2630) due to your merge queue CI optimization settings.
Jun 20, 7:22 PM UTC: Merged by the Graphite merge queue via draft PR: #2630.

## Changes

This was referenced Jun 12, 2025

chore(guard): fix log levels #2580

Closed

feat: db sh for workflows #2570

Closed

MasterPtato force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch 2 times, most recently from 392cfe6 to ac97bc8 Compare June 12, 2025 22:30

MasterPtato marked this pull request as ready for review June 12, 2025 22:30

MasterPtato requested a review from NathanFlurry June 12, 2025 22:30

greptile-apps bot reviewed Jun 12, 2025

View reviewed changes

MasterPtato force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch from ac97bc8 to f048c99 Compare June 12, 2025 23:04

MasterPtato force-pushed the 06-10-chore_guard_fix_log_levels branch from b3aa8b4 to 2e8e98f Compare June 12, 2025 23:04

MasterPtato force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch from f048c99 to 3a69467 Compare June 13, 2025 01:53

MasterPtato mentioned this pull request Jun 13, 2025

fix(cluster): fix pbi autoscaling #2592

Closed

MasterPtato changed the base branch from 06-10-chore_guard_fix_log_levels to graphite-base/2586 June 13, 2025 20:43

MasterPtato mentioned this pull request Jun 13, 2025

chore(pegboard): fix local cache bugs #2596

Closed

MasterPtato force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch from 3a69467 to e2238dc Compare June 13, 2025 22:55

MasterPtato force-pushed the graphite-base/2586 branch from 2e8e98f to 4a380a5 Compare June 13, 2025 22:55

MasterPtato changed the base branch from graphite-base/2586 to 06-10-chore_guard_fix_log_levels June 13, 2025 22:55

MasterPtato mentioned this pull request Jun 13, 2025

fix(api): handle wrapped operation errors #2602

Closed

NathanFlurry force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch from e2238dc to ff90f58 Compare June 15, 2025 20:24

NathanFlurry force-pushed the 06-10-chore_guard_fix_log_levels branch from 4a380a5 to 84aaf41 Compare June 15, 2025 20:24

MasterPtato force-pushed the 06-10-chore_guard_fix_log_levels branch from bc3dd6c to a8d0391 Compare June 18, 2025 23:47

MasterPtato force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch from 4ee85d0 to 66c9ae7 Compare June 18, 2025 23:47

This was referenced Jun 19, 2025

fix: figure out actor log shipping #2622

Closed

fix: get new actors working on docker compose #2623

Closed

NathanFlurry force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch from 66c9ae7 to ff90f58 Compare June 20, 2025 18:54

NathanFlurry force-pushed the 06-10-chore_guard_fix_log_levels branch from a8d0391 to 84aaf41 Compare June 20, 2025 18:54

MasterPtato force-pushed the 06-10-chore_guard_fix_log_levels branch from 84aaf41 to c33d751 Compare June 20, 2025 19:09

MasterPtato force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch from ff90f58 to a5dffdd Compare June 20, 2025 19:09

feat(pegboard): add local image cache and overlay fs mounts

a94aa4a

NathanFlurry force-pushed the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch from a5dffdd to a94aa4a Compare June 20, 2025 19:18

NathanFlurry force-pushed the 06-10-chore_guard_fix_log_levels branch from c33d751 to 5b30dea Compare June 20, 2025 19:18

graphite-app bot closed this Jun 20, 2025

graphite-app bot deleted the 06-12-feat_pegboard_add_local_image_cache_and_overlay_fs_mounts branch June 20, 2025 19:22

github-actions bot mentioned this pull request Jun 20, 2025

chore(main): release 25.5.1 #2423

Merged

NathanFlurry mentioned this pull request Jun 20, 2025

chore: fix merge conflicts #2634

Closed

This was referenced Jun 20, 2025

fix: add udp ports to docker compose #2635

Closed

feat: get multi actors working e2e on docker compose #2637

Closed

feat: add actor kv to runners #2638

Closed

feat: add actor queue #2644

Closed

fix: fix logs for new actors #2649

Closed

This was referenced Jun 28, 2025

fix(guard): use intercom_address for guard service discovery #2663

Closed

feat(actors): expose container system metrics #2664

Closed

chore: cargo fmt #2665

Closed

	const sleepDuration = (start + 60_000 - Date.now()) / 1000;
	const sleepDuration = (actorStart + 60_000 - Date.now()) / 1000;

feat(pegboard): add local image cache and overlay fs mounts #2586

feat(pegboard): add local image cache and overlay fs mounts #2586

Uh oh!

Conversation

MasterPtato commented Jun 12, 2025

Changes

Uh oh!

MasterPtato commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

cloudflare-workers-and-pages bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

MasterPtato commented Jun 12, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

graphite-app bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MasterPtato commented Jun 12, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 12, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 13, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 13, 2025 •

edited

Loading

graphite-app bot commented Jun 20, 2025 •

edited

Loading